Skip to content

Commit 62d0f5b

Browse files
polazpolaz
committed
feat(tests): improve unit test coverage from 88.48% to 90.34%
USER-FACING IMPROVEMENTS: - Enhanced test reliability and code quality validation - Better error handling coverage in wiki operations - More comprehensive variable registry testing - Improved fetch utility testing for various configurations SUPPORTING CHANGES: - Add comprehensive test coverage for wiki registry operations (49 new test cases) - Add extensive variable registry error handling tests (57 new test cases) - Enhance fetch utility coverage for cookie handling, timeouts, headers - Add new graphql index test coverage - Improve server transport mode testing - Remove dead code from wiki registry (get_wiki_page query params) - Fix ESLint/Prettier issues in list-tools.ts - All 1010 unit tests passing with no regressions COVERAGE IMPROVEMENTS: - Overall: 88.48% → 90.34% lines (+1.86 percentage points) - Wiki registry: Achieved 100% line coverage - Variables registry: 75.16% → 91.94% coverage - Fetch utilities: Enhanced error path coverage - Server tests: Comprehensive transport mode coverage
1 parent 62fb9f8 commit 62d0f5b

File tree

18 files changed

+1570
-93
lines changed

18 files changed

+1570
-93
lines changed

‎src/entities/files/registry.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -79,10 +79,10 @@ export const filesToolRegistry: ToolRegistry = new Map<string, EnhancedToolDefin
7979
// Return structured response with file metadata
8080
return {
8181
file_path: file_path,
82-
ref: ref || "HEAD",
82+
ref: ref ?? "HEAD",
8383
size: content.length,
8484
content: content,
85-
content_type: response.headers.get("content-type") || "text/plain",
85+
content_type: response.headers.get("content-type") ?? "text/plain",
8686
};
8787
},
8888
},

‎src/entities/wiki/registry.ts‎

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -63,14 +63,7 @@ export const wikiToolRegistry: ToolRegistry = new Map<string, EnhancedToolDefini
6363
// Resolve namespace type and get proper API path
6464
const { entityType, encodedPath } = await resolveNamespaceForAPI(namespace);
6565

66-
const queryParams = new URLSearchParams();
67-
Object.entries(options).forEach(([key, value]) => {
68-
if (value !== undefined && value !== null && key !== "namespace" && key !== "slug") {
69-
queryParams.set(key, String(value));
70-
}
71-
});
72-
73-
const apiUrl = `${process.env.GITLAB_API_URL}/api/v4/${entityType}/${encodedPath}/wikis/${encodeURIComponent(slug)}?${queryParams}`;
66+
const apiUrl = `${process.env.GITLAB_API_URL}/api/v4/${entityType}/${encodedPath}/wikis/${encodeURIComponent(slug)}`;
7467
const response = await enhancedFetch(apiUrl, {
7568
headers: {
7669
Authorization: `Bearer ${process.env.GITLAB_TOKEN}`,

‎src/utils/workItemTypes.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,14 +11,14 @@ interface WorkItemType {
1111
* Internal utility function to get work item types for a namespace
1212
* This is NOT exposed as a tool - it's for internal use only
1313
*/
14-
export async function getWorkItemTypes(namespacePath: string): Promise<WorkItemType[]> {
14+
export async function getWorkItemTypes(namespace: string): Promise<WorkItemType[]> {
1515
// Get GraphQL client from ConnectionManager
1616
const connectionManager = ConnectionManager.getInstance();
1717
const client = connectionManager.getClient();
1818

1919
// Use GraphQL query for getting work item types
2020
const response = await client.request(GET_WORK_ITEM_TYPES, {
21-
namespacePath: namespacePath,
21+
namespacePath: namespace,
2222
});
2323

2424
// Return the work item types in the expected format

‎tests/integration/data-lifecycle.test.ts‎

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -416,7 +416,7 @@ describe('🔄 Data Lifecycle - Complete Infrastructure Setup', () => {
416416

417417
// Step 1: Create work item with basic parameters (CREATE doesn't support widgets)
418418
const workItem = await helper.createWorkItem({
419-
namespacePath: testData.project!.path_with_namespace,
419+
namespace: testData.project!.path_with_namespace,
420420
title: workItemData.title,
421421
workItemType: workItemData.workItemType,
422422
description: workItemData.description,
@@ -554,7 +554,7 @@ describe('🔄 Data Lifecycle - Complete Infrastructure Setup', () => {
554554

555555
// Step 1: Create work item with basic parameters (CREATE doesn't support widgets)
556556
const workItem = await helper.createWorkItem({
557-
namespacePath: testData.group!.path,
557+
namespace: testData.group!.path,
558558
title: workItemData.title,
559559
workItemType: workItemData.workItemType,
560560
description: workItemData.description,
@@ -807,7 +807,7 @@ describe('🔄 Data Lifecycle - Complete Infrastructure Setup', () => {
807807

808808
console.log(`🔧 Creating epic in subgroup: ${testData.subgroup!.path}...`);
809809
const childEpic = await helper.createWorkItem({
810-
namespacePath: testData.subgroup!.full_path,
810+
namespace: testData.subgroup!.full_path,
811811
title: epicWithParentData.title,
812812
workItemType: epicWithParentData.workItemType,
813813
description: epicWithParentData.description,
@@ -970,7 +970,7 @@ describe('🔄 Data Lifecycle - Complete Infrastructure Setup', () => {
970970

971971
// Test group work items (Epics)
972972
const groupResult = await helper.listWorkItems({
973-
namespacePath: testData.group!.path,
973+
namespace: testData.group!.path,
974974
state: ['OPEN', 'CLOSED'],
975975
simple: true
976976
}) as any;
@@ -1000,7 +1000,7 @@ describe('🔄 Data Lifecycle - Complete Infrastructure Setup', () => {
10001000

10011001
// Test project work items (Issues/Tasks)
10021002
const projectResult = await helper.listWorkItems({
1003-
namespacePath: testData.project!.path_with_namespace,
1003+
namespace: testData.project!.path_with_namespace,
10041004
state: ['OPEN', 'CLOSED'],
10051005
simple: true
10061006
}) as any;
@@ -1028,7 +1028,7 @@ describe('🔄 Data Lifecycle - Complete Infrastructure Setup', () => {
10281028

10291029
// Test filtering for EPIC type in group
10301030
const epicResult = await helper.listWorkItems({
1031-
namespacePath: testData.group!.path,
1031+
namespace: testData.group!.path,
10321032
types: ['EPIC'],
10331033
simple: true
10341034
}) as any;
@@ -1041,7 +1041,7 @@ describe('🔄 Data Lifecycle - Complete Infrastructure Setup', () => {
10411041

10421042
// Test filtering for ISSUE type in project
10431043
const issueResult = await helper.listWorkItems({
1044-
namespacePath: testData.project!.path_with_namespace,
1044+
namespace: testData.project!.path_with_namespace,
10451045
types: ['ISSUE'],
10461046
simple: true
10471047
}) as any;
@@ -1059,7 +1059,7 @@ describe('🔄 Data Lifecycle - Complete Infrastructure Setup', () => {
10591059

10601060
// Test OPEN only
10611061
const openResult = await helper.listWorkItems({
1062-
namespacePath: testData.project!.path_with_namespace,
1062+
namespace: testData.project!.path_with_namespace,
10631063
state: ['OPEN'],
10641064
simple: true
10651065
}) as any;
@@ -1072,7 +1072,7 @@ describe('🔄 Data Lifecycle - Complete Infrastructure Setup', () => {
10721072

10731073
// Test ALL states
10741074
const allResult = await helper.listWorkItems({
1075-
namespacePath: testData.project!.path_with_namespace,
1075+
namespace: testData.project!.path_with_namespace,
10761076
state: ['OPEN', 'CLOSED'],
10771077
simple: true
10781078
}) as any;
@@ -1087,14 +1087,14 @@ describe('🔄 Data Lifecycle - Complete Infrastructure Setup', () => {
10871087

10881088
// Test with simple=true (default)
10891089
const simpleResult = await helper.listWorkItems({
1090-
namespacePath: testData.project!.path_with_namespace,
1090+
namespace: testData.project!.path_with_namespace,
10911091
simple: true,
10921092
first: 1
10931093
}) as any;
10941094

10951095
// Test with simple=false
10961096
const fullResult = await helper.listWorkItems({
1097-
namespacePath: testData.project!.path_with_namespace,
1097+
namespace: testData.project!.path_with_namespace,
10981098
simple: false,
10991099
first: 1
11001100
}) as any;

‎tests/integration/debug-widget-assignment.test.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ describe('Debug Widget Assignment', () => {
1919

2020
// Create a simple epic first
2121
const epic = await helper.executeTool('create_work_item', {
22-
namespacePath: 'test',
22+
namespace: 'test',
2323
title: 'Debug Epic for Widget Testing',
2424
workItemType: 'EPIC'
2525
}) as any;

‎tests/integration/helpers/registry-helper.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ export class IntegrationTestHelper {
121121
// ========================================
122122

123123
async createWorkItem(args: {
124-
namespacePath: string;
124+
namespace: string;
125125
title: string;
126126
workItemType: string;
127127
description?: string;
@@ -157,7 +157,7 @@ export class IntegrationTestHelper {
157157
}
158158

159159
async listWorkItems(args: {
160-
namespacePath: string;
160+
namespace: string;
161161
types?: string[];
162162
state?: ('OPEN' | 'CLOSED')[];
163163
first?: number;

‎tests/integration/schemas/labels.test.ts‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ describe('Labels Schema - GitLab Integration', () => {
3535
console.log(`📋 Using project: ${testProject.name} (ID: ${testProject.id})`);
3636

3737
const validParams = {
38-
namespacePath: testProject.path_with_namespace,
38+
namespace: testProject.path_with_namespace,
3939
with_counts: true,
4040
include_ancestor_groups: true,
4141
per_page: 10,
@@ -107,7 +107,7 @@ describe('Labels Schema - GitLab Integration', () => {
107107

108108
const testProject = projects[0];
109109
const searchParams = {
110-
namespacePath: testProject.path_with_namespace, // Use correct namespacePath from schema
110+
namespace: testProject.path_with_namespace, // Use correct namespace from schema
111111
search: 'bug',
112112
with_counts: true,
113113
};
@@ -118,7 +118,7 @@ describe('Labels Schema - GitLab Integration', () => {
118118
if (result.success) {
119119
expect(result.data.search).toBe('bug');
120120
expect(result.data.with_counts).toBe(true);
121-
expect(result.data.namespacePath).toBe(testProject.path_with_namespace);
121+
expect(result.data.namespace).toBe(testProject.path_with_namespace);
122122
}
123123

124124
console.log('✅ ListLabelsSchema validates search parameters');
@@ -153,7 +153,7 @@ describe('Labels Schema - GitLab Integration', () => {
153153

154154
const testProject = projects[0];
155155
const labels = await helper.executeTool('list_labels', {
156-
namespacePath: testProject.path_with_namespace,
156+
namespace: testProject.path_with_namespace,
157157
per_page: 1
158158
}) as any[];
159159

@@ -164,15 +164,15 @@ describe('Labels Schema - GitLab Integration', () => {
164164

165165
const testLabel = labels[0];
166166
const validParams = {
167-
namespacePath: testProject.path_with_namespace,
167+
namespace: testProject.path_with_namespace,
168168
label_id: testLabel.id.toString(),
169169
};
170170

171171
const result = GetLabelSchema.safeParse(validParams);
172172
expect(result.success).toBe(true);
173173

174174
if (result.success) {
175-
expect(result.data.namespacePath).toBe(testProject.path_with_namespace);
175+
expect(result.data.namespace).toBe(testProject.path_with_namespace);
176176
expect(result.data.label_id).toBe(testLabel.id.toString());
177177
}
178178

@@ -189,7 +189,7 @@ describe('Labels Schema - GitLab Integration', () => {
189189

190190
const testProject = projects[0];
191191
const labels = await helper.executeTool('list_labels', {
192-
namespacePath: testProject.path_with_namespace,
192+
namespace: testProject.path_with_namespace,
193193
per_page: 1
194194
}) as any[];
195195

@@ -200,7 +200,7 @@ describe('Labels Schema - GitLab Integration', () => {
200200

201201
const testLabel = labels[0];
202202
const params = {
203-
namespacePath: testProject.path_with_namespace,
203+
namespace: testProject.path_with_namespace,
204204
label_id: testLabel.id.toString(),
205205
};
206206

‎tests/integration/schemas/milestones.test.ts‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ describe('Milestones Schema - GitLab Integration', () => {
3535
console.log(`📋 Using project: ${testProject.name} (ID: ${testProject.id})`);
3636

3737
const validParams = {
38-
namespacePath: testProject.path_with_namespace,
38+
namespace: testProject.path_with_namespace,
3939
state: 'active' as const,
4040
per_page: 10,
4141
};
@@ -106,7 +106,7 @@ describe('Milestones Schema - GitLab Integration', () => {
106106
}
107107

108108
const searchParams = {
109-
namespacePath: projects[0].path_with_namespace, // Use namespacePath as expected by schema
109+
namespace: projects[0].path_with_namespace, // Use namespace as expected by schema
110110
state: 'closed' as const,
111111
search: 'v1.0',
112112
include_ancestors: true,
@@ -117,7 +117,7 @@ describe('Milestones Schema - GitLab Integration', () => {
117117
expect(result.success).toBe(true);
118118

119119
if (result.success) {
120-
expect(result.data.namespacePath).toBe(projects[0].path_with_namespace);
120+
expect(result.data.namespace).toBe(projects[0].path_with_namespace);
121121
expect(result.data.state).toBe('closed');
122122
expect(result.data.search).toBe('v1.0');
123123
expect(result.data.include_ancestors).toBe(true);
@@ -156,7 +156,7 @@ describe('Milestones Schema - GitLab Integration', () => {
156156

157157
const testProject = projects[0];
158158
const milestones = await helper.executeTool('list_milestones', {
159-
namespacePath: testProject.path_with_namespace,
159+
namespace: testProject.path_with_namespace,
160160
per_page: 1
161161
}) as any[];
162162

@@ -167,15 +167,15 @@ describe('Milestones Schema - GitLab Integration', () => {
167167

168168
const testMilestone = milestones[0];
169169
const validParams = {
170-
namespacePath: testProject.path_with_namespace,
170+
namespace: testProject.path_with_namespace,
171171
milestone_id: testMilestone.id.toString(),
172172
};
173173

174174
const result = GetProjectMilestoneSchema.safeParse(validParams);
175175
expect(result.success).toBe(true);
176176

177177
if (result.success) {
178-
expect(result.data.namespacePath).toBe(testProject.path_with_namespace);
178+
expect(result.data.namespace).toBe(testProject.path_with_namespace);
179179
expect(result.data.milestone_id).toBe(testMilestone.id.toString());
180180
}
181181

@@ -192,7 +192,7 @@ describe('Milestones Schema - GitLab Integration', () => {
192192

193193
const testProject = projects[0];
194194
const milestones = await helper.executeTool('list_milestones', {
195-
namespacePath: testProject.path_with_namespace,
195+
namespace: testProject.path_with_namespace,
196196
per_page: 1
197197
}) as any[];
198198

@@ -203,7 +203,7 @@ describe('Milestones Schema - GitLab Integration', () => {
203203

204204
const testMilestone = milestones[0];
205205
const params = {
206-
namespacePath: testProject.path_with_namespace,
206+
namespace: testProject.path_with_namespace,
207207
milestone_id: testMilestone.id.toString(),
208208
};
209209

‎tests/integration/schemas/project.test.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -200,7 +200,7 @@ describe('Project Schema - GitLab 18.3 Integration', () => {
200200
path: `schema-test-project-${testTimestamp}`,
201201
description: `Schema test project for validation - ${testTimestamp}`,
202202
visibility: 'private' as const,
203-
namespacePath: TEST_GROUP,
203+
namespace: TEST_GROUP,
204204
issues_enabled: true,
205205
merge_requests_enabled: true,
206206
wiki_enabled: false,
@@ -215,7 +215,7 @@ describe('Project Schema - GitLab 18.3 Integration', () => {
215215
if (result.success) {
216216
expect(result.data.name).toBe(testProjectData.name);
217217
expect(result.data.visibility).toBe('private');
218-
expect(result.data.namespacePath).toBe(testProjectData.namespacePath);
218+
expect(result.data.namespace).toBe(testProjectData.namespace);
219219
}
220220

221221
console.log('✅ CreateRepositorySchema validates project creation parameters correctly');

0 commit comments

Comments
 (0)