Skip to content

Deprecate save() #887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anniel-stripe merged 4 commits into from
Oct 24, 2022
Merged

Deprecate save() #887

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5b409b8
Add deprecation message and update NotImplementedError in modify()
anniel-stripe Oct 19, 2022
c9b8505
Update deprecation message
anniel-stripe Oct 24, 2022
870518f
Change to deprecation warning
anniel-stripe Oct 24, 2022
bdab77d
Revert back to docstring
anniel-stripe Oct 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Revert back to docstring
  • Loading branch information
@anniel-stripe
anniel-stripe committed Oct 24, 2022
commit bdab77dcf008cde0eac060b5b28e903d3c62588c
13 changes: 5 additions & 8 deletions stripe/api_resources/abstract/updateable_api_resource.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
from stripe.api_resources.abstract.api_resource import APIResource
from stripe.six.moves.urllib.parse import quote_plus

import warnings

class UpdateableAPIResource(APIResource):
@classmethod
Expand All @@ -13,13 +12,11 @@ def modify(cls, sid, **params):
return cls._static_request("post", url, params=params)

def save(self, idempotency_key=None):
warnings.warn(
"""
The `save` method is deprecated and will be removed in
a future major version of the library.
Use the class method `modify` on the resource instead.
""",
DeprecationWarning)
"""
The `save` method is deprecated and will be removed in a future major version of the library.

Use the class method `modify` on the resource instead.
"""
updated_params = self.serialize(None)
if updated_params:
self._request_and_refresh(
Expand Down