Fix DeprecationWarning when encoding StripeObject metadata (fixes #1651) #1687
+128
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
praniketkw
requested review from
xavdid-stripe
and removed request for
a team
ramya-stripe
requested review from
prathmesh-stripe
and removed request for
xavdid-stripe
ramya-stripe
requested review from
ramya-stripe
and removed request for
prathmesh-stripe
ramya-stripe
reviewed
Dec 9, 2025
Contributor
|
@praniketkw Can you also update the PR description based on the new approach? |
Contributor
Author
|
@ramya-stripe Done! |
| if value is None: | ||
| continue | ||
| elif hasattr(value, "stripe_id"): | ||
| yield (key, value.stripe_id) |
Contributor
There was a problem hiding this comment.
Hey @praniketkw
Just thought of an alternative with a smaller footprint. Can you try this and see if it works?
elif hasattr(value, "stripe_id")
yield (key, getattr(value, "id"))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1651
Why?
When updating metadata on resources like invoices, users encountered a DeprecationWarning even though they were using the public API correctly. The warning was triggered internally when the encoder checked for the deprecated stripe_id property on StripeObject instances. While the deprecation warning serves an important purpose for direct user access to stripe_id, it should not be shown for internal library usage.
What?