Even more type annotations #1088
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardm-stripe
force-pushed
the
richardm-more-types-2
branch
from
49f21ba to
9e556ea
Compare
pakrym-stripe
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this one, the goal is to fully type
StripeObject. I add# pyright: strictto the top, and also make sure every method has a return annotation. Now,pyright --verifytypesno longer complains aboutType of base class "stripe.stripe_object.StripeObject" is partially unknownfor the (many) classes that inherit from StripeObject.The really hard thing, that I haven't been ready to tackle yet, is coming up with good types for
stripe.http_client, so there are some pretty unsatisfyingAnyand casts in this one, but I'm hoping that adding types around the periphery will make it easier to tackle eventually.Pyright reports
after this (up from 94.3%)