Remove __future__ imports and use generated sections in object_classes.py
#1069
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pakrym-stripe
suggested changes
Oct 11, 2023
Contributor
pakrym-stripe
left a comment
pakrym-stripe
left a comment
There was a problem hiding this comment.
A lot of unrelated changes.
pakrym-stripe
approved these changes
Oct 11, 2023
richardm-stripe
added a commit
that referenced
this pull request
Oct 11, 2023
* Bump version to 6.7.0 * Better types for search result methods (#1070) * Remove `__future__` imports and use generated sections in `object_classes.py` (#1069) * Use generated section in object classes file * Remove generated __future__ imports * Remove manual __future__ imports * Business objects -> Object classes * regenerate * Update generated code for v597 (#1071) Co-authored-by: Stripe OpenAPI <105521251+stripe-openapi[bot]@users.noreply.github.com> * wip * Properly deserialize beneath map types * Generate nested resource classes * Don't filter out Nones --------- Co-authored-by: Annie Li <[email protected]> Co-authored-by: anniel-stripe <[email protected]> Co-authored-by: stripe-openapi[bot] <105521251+stripe-openapi[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
from __future__ import absolute_import, division, print_functionimports. These imports are no longer necessary, as they are used for forwards compatibility with Python 2.x versions and became the default behavior in Python 3.0 (see https://docs.python.org/3/library/__future__.html). Since stripe-python supports Python >=3.6 as of v6.0.0, this is a non-breaking change.stripe/object_classes.pyto use generated sections, allowing us to manually maintain data structure objects likeListObject(see commit).