Types: inner resource classes #1061
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardm-stripe
changed the title
richardm-stripe
force-pushed
the
richardm-nested-object
branch
2 times, most recently
from
a5e4902 to
42c1964
Compare
…sses.py` (#1069) * Use generated section in object classes file * Remove generated __future__ imports * Remove manual __future__ imports * Business objects -> Object classes * regenerate
Co-authored-by: Stripe OpenAPI <105521251+stripe-openapi[bot]@users.noreply.github.com>
richardm-stripe
force-pushed
the
richardm-nested-object
branch
from
42c1964 to
b040115
Compare
richardm-stripe
force-pushed
the
richardm-nested-object
branch
from
b040115 to
28c5650
Compare
pakrym-stripe
approved these changes
Oct 11, 2023
Contributor
pakrym-stripe
left a comment
pakrym-stripe
left a comment
There was a problem hiding this comment.
I should learn to read.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces
StripeObjecttypes on resource classes with more granular classes that define the specific fields that can be accessed.This is not just a type annotation change. We also change the deserialization code in
StripeObject.refresh_fromandutil.convert_to_stripe_objectso, in order that the type annotations tell the truth, at runtime, theseStripeObjectclasses will be instances of the more specific classes that are children ofStripeObject.We don't consider changing objects to a more specific subclass to be a breaking change, however, it's possible that any code that uses
type(...) == StripeObjectinstead ofinstanceof(StripeObject, ...), or does similar introspection, will be affected by this change,Into
betafor now.Note: There is a very obscure breaking change here:
PromotionCode.restrictions.currency_optionswill now be of typedictinstead ofStripeObject.