Added requestCollection and requestSearchResult to StripeClientInterface #1832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prathmesh-stripe
requested review from
xavdid-stripe
and removed request for
a team
jar-stripe
reviewed
Mar 27, 2025
jar-stripe
reviewed
Mar 27, 2025
auto-merge was automatically disabled
March 27, 2025 22:26
Head branch was modified
prathmesh-stripe
force-pushed
the
prathmesh/add-request-to-stripeclientinterface
branch
from
352fc1a to
7de4c7f
Compare
jar-stripe
approved these changes
Mar 27, 2025
prathmesh-stripe
deleted the
prathmesh/add-request-to-stripeclientinterface
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
We are adding new helper methods to
StripeClientInterfaceto improve the return types in SDKs.Stripe's implementation in BaseStripeClient.
See Also
https://jira.corp.stripe.com/browse/DEVSDK-2458#L80-L94
Changelog
requestSearchResult,requestCollectiontoStripeClientInterface. Developers building custom StripeClient will now have to implement these new methods.