Merge into beta using the merge script #1770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…more" This reverts commit 002550f.
Co-authored-by: Stripe OpenAPI <105521251+stripe-openapi[bot]@users.noreply.github.com>
examples/meter_event_stream.php
Outdated
|
|
||
| require 'vendor/autoload.php'; // Make sure to include Composer's autoload file | ||
|
|
||
| class meter_event_stream |
There was a problem hiding this comment.
This file needs to be renamed to MeterEventStream.php and
Suggested change
| class meter_event_stream | |
| class MeterEventStream |
examples/meter_event_stream.php
Outdated
| $apiKey = '{{API_KEY}}'; | ||
| $customerId = '{{CUSTOMER_ID}}'; | ||
|
|
||
| $manager = new MeterEventManager($apiKey); |
There was a problem hiding this comment.
Suggested change
| $manager = new MeterEventManager($apiKey); | |
| $manager = new MeterEventStream($apiKey); |
examples/new_example.php
Outdated
| // require 'vendor/autoload.php'; // Make sure to include Composer's autoload file | ||
| require '../init.php'; | ||
|
|
||
| class new_example |
There was a problem hiding this comment.
Similarly NewExample.php and
Suggested change
| class new_example | |
| class NewExample |
prathmesh-stripe
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we merged from master to beta yesterday, we should have used our merge script and then NOT used the squash option when merging the PR as this results in future merges by the automation to not know how to resolve certain merge conflicts.
This PR has the changes from running our merge script and resolving the resulting merge conflicts.
Additionally, there is a commit with changes resulting from running the codegen - not sure why this was not part of yesterday's changes
Note: DO NOT use the squash option when merging