Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type of Billing Meter Event #1758

Merged
merged 2 commits into from
Sep 28, 2024
Merged

Fix type of Billing Meter Event #1758

merged 2 commits into from
Sep 28, 2024

Conversation

prathmesh-stripe
Copy link
Contributor

@prathmesh-stripe prathmesh-stripe commented Sep 27, 2024 •
edited
Loading

fetchRelatedObject could not correctly return v1 objects. Therefore I had to manually add that type in v2mapping.

$baseEvent = $stripeClient->v2->core->events->retrieve('evt_test_65RD9HQIXX53rfbiu8116QQCIX1TSQbbOu5RHvml0KWLTM');

//print_r($baseEvent);
if ($baseEvent instanceof \Stripe\Events\V1BillingMeterErrorReportTriggeredEvent) {
    print_r($baseEvent->fetchRelatedObject()); // Returns StripeObject. Should return \Stripe\Billing\Meter
}

Followup to move this to codegen: https://jira.corp.stripe.com/browse/DEVSDK-2204

@jar-stripe
Copy link
Contributor

very small nit but can you remove that commented print_r from the PR description?

xavdid-stripe
xavdid-stripe approved these changes Sep 28, 2024
View reviewed changes
Copy link
Member

@xavdid-stripe xavdid-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is fine, but could have been fixed in https://github.com/stripe/sdk-codegen/pull/1777

We should probably generalize that approach

jar-stripe
jar-stripe approved these changes Sep 28, 2024
View reviewed changes
Copy link
Contributor

@jar-stripe jar-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, pending a couple of non-blocking comments!

@prathmesh-stripe prathmesh-stripe merged commit 64e749b into sdk-release/next-major Sep 28, 2024
22 checks passed
@prathmesh-stripe prathmesh-stripe deleted the prathmesh/fix-related-object-v1-types branch September 28, 2024 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xavdid-stripe xavdid-stripe xavdid-stripe approved these changes

@jar-stripe jar-stripe jar-stripe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@prathmesh-stripe @jar-stripe @xavdid-stripe