Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increment PHPStan to strictness level 2 #1488

Merged
merged 10 commits into from
Apr 27, 2023
Merged

Increment PHPStan to strictness level 2 #1488

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
eb00fae
Increment phpstan level
richardm-stripe Apr 27, 2023
99b8fd2
Fix incorrect docblock
richardm-stripe Apr 27, 2023
df88220
Add property annotation for $id (accessible via magic method on Strip…
richardm-stripe Apr 27, 2023
6ef895a
Fix unsafe static:: references
richardm-stripe Apr 27, 2023
f20310d
Suppress errors related to incomplete StripeClientInterface
richardm-stripe Apr 27, 2023
8313ac9
Malformed docstring
richardm-stripe Apr 27, 2023
8ca4a54
Add TODO to remove legal_entity logic
richardm-stripe Apr 27, 2023
7156670
AccountTest
richardm-stripe Apr 27, 2023
e9ee21f
Fix tests
richardm-stripe Apr 27, 2023
8d74c4b
Merge branch 'master' into richardm-phpstan-stricter
richardm-stripe Apr 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix unsafe static:: references
  • Loading branch information
@richardm-stripe
richardm-stripe committed Apr 27, 2023
commit 6ef895a85b7abfee80c311e07e8649340ce191dd
4 changes: 2 additions & 2 deletions lib/ApiRequestor.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,7 +325,7 @@ private static function _defaultHeaders($apiKey, $clientInfo = null)
$uaString = 'Stripe/v1 PhpBindings/' . Stripe::VERSION;

$langVersion = \PHP_VERSION;
$uname_disabled = static::_isDisabled(\ini_get('disable_functions'), 'php_uname');
$uname_disabled = self::_isDisabled(\ini_get('disable_functions'), 'php_uname');
$uname = $uname_disabled ? '(disabled)' : \php_uname();

$appInfo = Stripe::getAppInfo();
Expand Down Expand Up @@ -377,7 +377,7 @@ private function _prepareRequest($method, $url, $params, $headers)

if ($params && \is_array($params)) {
$optionKeysInParams = \array_filter(
static::$OPTIONS_KEYS,
self::$OPTIONS_KEYS,
function ($key) use ($params) {
return \array_key_exists($key, $params);
}
Expand Down
8 changes: 4 additions & 4 deletions lib/Service/AbstractService.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,22 +72,22 @@ private static function formatParams($params)

protected function request($method, $path, $params, $opts)
{
return $this->getClient()->request($method, $path, static::formatParams($params), $opts);
return $this->getClient()->request($method, $path, self::formatParams($params), $opts);
}

protected function requestStream($method, $path, $readBodyChunkCallable, $params, $opts)
{
return $this->getStreamingClient()->requestStream($method, $path, $readBodyChunkCallable, static::formatParams($params), $opts);
return $this->getStreamingClient()->requestStream($method, $path, $readBodyChunkCallable, self::formatParams($params), $opts);
}

protected function requestCollection($method, $path, $params, $opts)
{
return $this->getClient()->requestCollection($method, $path, static::formatParams($params), $opts);
return $this->getClient()->requestCollection($method, $path, self::formatParams($params), $opts);
}

protected function requestSearchResult($method, $path, $params, $opts)
{
return $this->getClient()->requestSearchResult($method, $path, static::formatParams($params), $opts);
return $this->getClient()->requestSearchResult($method, $path, self::formatParams($params), $opts);
}

protected function buildPath($basePath, ...$ids)
Expand Down
8 changes: 4 additions & 4 deletions lib/Util/CaseInsensitiveArray.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ public function getIterator()
#[\ReturnTypeWillChange]
public function offsetSet($offset, $value)
{
$offset = static::maybeLowercase($offset);
$offset = self::maybeLowercase($offset);
if (null === $offset) {
$this->container[] = $value;
} else {
Expand All @@ -59,7 +59,7 @@ public function offsetSet($offset, $value)
#[\ReturnTypeWillChange]
public function offsetExists($offset)
{
$offset = static::maybeLowercase($offset);
$offset = self::maybeLowercase($offset);

return isset($this->container[$offset]);
}
Expand All @@ -70,7 +70,7 @@ public function offsetExists($offset)
#[\ReturnTypeWillChange]
public function offsetUnset($offset)
{
$offset = static::maybeLowercase($offset);
$offset = self::maybeLowercase($offset);
unset($this->container[$offset]);
}

Expand All @@ -80,7 +80,7 @@ public function offsetUnset($offset)
#[\ReturnTypeWillChange]
public function offsetGet($offset)
{
$offset = static::maybeLowercase($offset);
$offset = self::maybeLowercase($offset);

return isset($this->container[$offset]) ? $this->container[$offset] : null;
}
Expand Down