Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to inject service instances to the factory #1350

Closed
wants to merge 3 commits into from
Closed

Ability to inject service instances to the factory #1350

wants to merge 3 commits into from
+23 −0

Conversation

cangelis
Copy link

Instances resolved externally can be passed to the factory. This is useful for the mock services that are created in unit tests.

Example use case (using Laravel's mock method which uses Mockery under the hood);

$client = app(StripeClient::class);

$customerService = $this->mock(CustomerService::class, function ($mock) {
    $mock->shouldReceive('retrieve')->andReturn(Customer::constructFrom('......'));
});

$client->getFactory()->setServiceInstance(CustomerService::class, $customerService);

// returns the mock
$client->customers;

@cangelis
Ability to inject service instances to the factory
812f55a 
Instances resolved externally can be passed to the factory. This is useful for the mock services that are created in unit tests
@CLAassistant
Copy link

CLAassistant commented Aug 17, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@pakrym-stripe
Copy link
Contributor

Hey @cangelis, sorry for a delayed response. We were thinking about the problem of mocking StripeClient properties and came up with alternative solution of making the __get itself mockable by exposing it as a named method. Can you check if the solution form the above PR works for you case?

@richardm-stripe richardm-stripe mentioned this pull request Oct 17, 2022
Merged
@pakrym-stripe
Copy link
Contributor

I've closed this as superseded by #1381. Please file an issue if we can improve service mocking in other ways.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardm-stripe richardm-stripe richardm-stripe left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cangelis @CLAassistant @pakrym-stripe @richardm-stripe