-
Notifications
You must be signed in to change notification settings - Fork 870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run tests for PHP 8 #1199
Run tests for PHP 8 #1199
Conversation
Well, I suppose it's not that easy because the codebase doesn't support PHP 8 :( |
@hivokas Correct it's unfortunately not easy to add support for this. All the tools we use are either locked on older versions or require dropping older versions of PHP to support PHP 8. While it's something we really want to offer, it'd mean dropped PHP 5.6 and PHP 7.0 which are unfortunately still widely used by developers using Stripe today. |
@remi-stripe I've found this branch in this repo: 84c077c. I believe test cases can be updated to be supported both by PHP 5.6 and PHP 8, both by PHPUnit 5.7 and PHPUnit 9 by not using asserts that are missing either in PHPUnit 5.7 or PHPUnit 9. Then, |
cc @richardm-stripe can you have a look at the PR and see whether this is a viable path forward? |
@remi-stripe I still think that just branching to a new major version is the best way to go to modernize the SDK and drop a bunch of old PHP versions. You can simultaneously support the new major version and the old one so nobody gets left behind. |
This was subsumed by #1209, which began running CI for both PHP8 and PHP8.1. |
This is great @richardm-stripe! Thanks! |
No description provided.