Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PHP 8.1 compatibility with new interface types #1182

Closed
wants to merge 4 commits into from

Conversation

kylekatarnls
Copy link

No description provided.

@CLAassistant
Copy link

CLAassistant commented Sep 18, 2021

CLA assistant check
All committers have signed the CLA.

@chrisdeeming
Copy link

Aside from the failing checks (not sure why they failed) is there any reason this hasn't been merged in yet, @richardm-stripe?

We're aiming to add support for PHP 8.1 in the coming weeks and this will be one fewer package that I have to fork and maintain in order to add the attributes required to keep PHP 8.1 happy.

To be clear, the ReturnTypeWillChange attribute will not functionally affect anything and the suggested changes made by @kylekatarnls seem to be correct.

@richardm-stripe
Copy link
Contributor

Hello @chrisdeeming, thank you for submitting this. This should have been subsumed by #1211 and #1209, and released in v7.104.0 today, which added the ReturnTypeWillChange annotation to all the appropriate locations.

@spaze
Copy link
Contributor

spaze commented Dec 1, 2021

Hi @richardm-stripe,

This should have been subsumed by #1211 and #1209

seems that a few were missed so I've created #1213 to add them. Looking forward to have those added too! Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants