Use TextEncoder instead of Buffer to ensure support in other JS environments
#2500
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
xavdid-stripe
approved these changes
Nov 12, 2025
Member
xavdid-stripe
left a comment
xavdid-stripe
left a comment
There was a problem hiding this comment.
Awesome, thanks for fixing! And sorry about the hassle.
Once you sign the CLA, we can merge!
xavdid-stripe
changed the title
TextEncoder instead of Buffer to ensure support in other JS environments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
See #2499 bug description. Buffer is only available in node.js enviroments
What?
Changed it to TextEncoder which is widely available in all Javascript enviroments and does the same thing