Update v2 array parameter serialization to use indexed format #2497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates v2 array parameter serialization to use indexed format (?include[0]=foo&include[1]=bar) instead of repeated format (?include=foo&include=bar), making it consistent with v1 behavior. Modified src/utils.ts to always use 'indices' arrayFormat in qs.stringify, and updated test expectations in test/utils.spec.ts to reflect the new behavior. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]> Committed-By-Agent: claude
mbroshi-stripe
requested review from
xavdid-stripe
and removed request for
a team
xavdid-stripe
approved these changes
Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
Stripe has updated how array parameters are handled in
GETandDELETEmethods to/v2endpoints. Previously, the SDKs were serializing them with repeated parameter format (e.g.,?include=foo&include=bar) since that is was the API expected. While that format is still accepted, it is deprecated. Instead, we will serialize array parameters to use indexed format (e.g.,?include[0]=foo&include[1]=bar), which is the preferred method going forward. This aligns v2 behavior with v1 for consistency.What?
src/utils.tsto always use 'indices' arrayFormat in qs.stringifytest/utils.spec.tsto reflect new behaviorChangelog
RetrieveandListcalls for/v2endpoints now use indexed format (e.g.,?include[0]=foo&include[1]=bar) instead of repeated parameter format (e.g.,?include=foo&include=bar) when communicating with the Stripe API. This may break any unit tests that expect the latter behavior when setting up a mock server. Instead, they should now expect the former.