correctly calculate content-length for JSON bodies that contain unicode #2485
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xavdid-stripe
requested review from
mbroshi-stripe
and removed request for
a team
mbroshi-stripe
approved these changes
Nov 3, 2025
Contributor
mbroshi-stripe
left a comment
mbroshi-stripe
left a comment
There was a problem hiding this comment.
Looks good. Had a non-blocking question
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
We got reports of 400 errors when users called v2 endpoints w/ unicode strings in the body.
The root cause was the API ingress proxy counting bytes more accurately than the Node SDK. We were underreporting and it was giving a confusing error message back as a result.
What?
See Also