Skip to content

Add missing Javadoc #729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ob-stripe merged 1 commit into from
Apr 9, 2019
Merged

Add missing Javadoc #729

ob-stripe merged 1 commit into from
Apr 9, 2019

Conversation

@ob-stripe
Copy link
Contributor

@ob-stripe ob-stripe commented Apr 9, 2019

r? @mickjermsurawong-stripe @remi-stripe
cc @stripe/api-libraries

Adds missing Javadoc on non-generated resource classes.

@ob-stripe ob-stripe mentioned this pull request Apr 9, 2019
Merged
9 tasks
remi-stripe
remi-stripe approved these changes Apr 9, 2019
View reviewed changes
Copy link
Contributor

@remi-stripe remi-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some minor comments, up to you!

@mickjermsurawong-stripe
Copy link
Contributor

mickjermsurawong-stripe commented Apr 9, 2019

@ob-stripe

  • On the event "account", if the wording I proposed seems okay, we can add to the java doc? At least we will have parity with OpenAPI on this.
  • For File doc on "All of Stripe’s officially supported API libraries...", I think it's okay to remove it from the non-autogen classes. But I'm fine leaving as is too.

@stripe-ci stripe-ci removed the approved label Apr 9, 2019
@ob-stripe ob-stripe merged commit a917ac3 into integration-v9 Apr 9, 2019
@ob-stripe ob-stripe deleted the ob-javadoc branch April 9, 2019 18:39
@ob-stripe ob-stripe restored the ob-javadoc branch April 9, 2019 18:39
@ob-stripe ob-stripe deleted the ob-javadoc branch April 9, 2019 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@remi-stripe remi-stripe remi-stripe approved these changes

+1 more reviewer

@mickjermsurawong-stripe mickjermsurawong-stripe mickjermsurawong-stripe left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@ob-stripe ob-stripe

Labels

approved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ob-stripe @mickjermsurawong-stripe @remi-stripe @stripe-ci