Use ErrorProne in builds #713
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Oh oops, I just realized that We'd need to have the generator add the |
Contributor
|
@ob-stripe |
Contributor
|
On @OverRide id. I can add that in the generator. Sorry didn't manage to get to. |
ob-stripe
force-pushed
the
integration-v9
branch
from
8fb1316 to
4d642f5
Compare
ob-stripe
force-pushed
the
ob-errorprone
branch
2 times, most recently
from
1735f69 to
0e2f06d
Compare
Merged
Contributor
Author
|
Okay, this should be ready now. ptal @mickjermsurawong-stripe |
Contributor
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @mickjermsurawong-stripe
cc @stripe/api-libraries
Use ErrorProne in builds.
Fixes #497.
There were only three issues remaining, two of which I think we can ignore:
ScheduledQueryRun.Error: ErrorProne complains thatErroris a builtin class injava.langand we should change the name. Given thatScheduledQueryRun.Erroris a nested class and it's very unlikely any user would import it directly, I think it's safe to ignore this.assertTrue(subscription.getTaxPercent().equals(new BigDecimal("0.3"))): ErrorProne warns thatBigDecimal.equalscompares the scale of the representation as well as the value (i.e.1.0 != 1.00). This is actually desirable in our case, so this is a false positive.Unfortunately, the last one is another missing@Overridein autogenerated code, here:stripe-java/src/main/java/com/stripe/model/ExternalAccountTypeAdapterFactory.java
Line 83 in 7518b68
Not sure how hard it would be to fix this. wdyt?Fixed, thanks Mick!