Generated for V9.0 [generated] source: spec3.sdk.yaml@non-master-spec-fb07de8 in mickjer… #711

mickjermsurawong-stripe · 2019-03-29T03:33:11Z

Gen typed params (based on the groundwork in autogen-params branch)
Two first two commits are generated.

First contains the new param files to be added.
Second contains the modified model classes that now takes methods with typed params
cc @stripe/api-libraries
r? @remi-stripe
cc @ob-stripe

src/main/java/com/stripe/param/TokenCreateParams.java

src/main/java/com/stripe/param/CustomerCreateParams.java

src/main/java/com/stripe/param/SubscriptionUpdateParams.java

src/main/java/com/stripe/param/SubscriptionCreateParams.java

src/main/java/com/stripe/param/PaymentMethodCreateParams.java

remi-stripe

Okay I looked at random files and they all look correct to me. I flagged minor things but no blocker from me anymore

src/main/java/com/stripe/param/PaymentMethodCreateParams.java

src/main/java/com/stripe/param/TokenCreateParams.java

remi-stripe · 2019-03-30T01:59:01Z

src/main/java/com/stripe/param/SubscriptionCancelParams.java

+     */
+    public Builder setProrate(Boolean prorate) {
+      this.prorate = prorate;
+      return this;


OOC how do we handle the case where it's not set/initialized versus when you explicitly set false? I want to make sure we don't have the issue we had with stripe-go for years.

Yup it will be set as null, because we use this Boolean object and not primitive type boolean.

mickjermsurawong-stripe · 2019-04-04T22:42:53Z

@ob-stripe this last commit here has generated code with EnumParam and EmptyParam.
This branch is based on autogen-param which is already based on integration-v9.
If you could help to do error prune pass on this please.

ob-stripe · 2019-04-05T00:04:10Z

@mickjermsurawong-stripe Just ran Error Prone (not "Prune" though that could work too! 😛). The main issue is that this attribute in all enum classes:

@Getter private final String value;

is lacking the @Override annotation, e.g.:

/Users/ob/workspace/java/stripe-java/src/main/java/com/stripe/param/PaymentMethodCreateParams.java:485: warning: [MissingOverride] getValue implements method in EnumParam; expected @Override
    @Getter private final String value;
    ^
    (see https://errorprone.info/bugpattern/MissingOverride)
  Did you mean '@Override @Getter private final String value;'?

There are also a few other issues in tests, but let's fix the issue in generated code first and I'll re-run Error Prone after.

mickjermsurawong-stripe · 2019-04-05T02:03:13Z

whoops haha thanks ob! yah ErrorPrune sounds a better name to me!

mickjermsurawong-stripe · 2019-04-05T20:59:31Z

@remi-stripe I've addressed all the pending issues.
Do you have more thoughts on this?
I will also do my own spot check against API refs.
Do you suggest any particular params endpoints I should invest my time into?

test: use new empty param

test: Token with ObjectType enum test: typed params create token

test: typed params charge

…msurawong/working-autogen

…spec3.sdk.yaml@non-master-spec-d9e92b9 in mickjermsurawong/working-autogen

…-master-spec-c5dbddd in mickjermsurawong/working-autogen

…ec-97a62f7 in gen-param-default

…msurawong/default-gen-param

mickjermsurawong-stripe · 2019-04-08T22:01:14Z

Going to self-approve this merging this to autogen-params
Having the details of the change PR fleshed out in sdk-autogen-java PR sdk-autogen-java/pull/58
LGTM

@OverRide

…-fb07de8 in mickjer… (#711) * test: typed params path query expand and limit * test: typed params on methods previously had params as string constant * test: typed params on polymoprhic of EMPTY and array test: use new empty param * test: typed params on inner object * test: typed params by collection methods * test: typed param fix to singular * test: typed param create token with different instruments test: Token with ObjectType enum test: typed params create token * test: typed params create charge test: typed params charge * generated: param * generated: model * generated: param * [generated] source: spec3.sdk.yaml@non-master-spec-d9e92b9 in mickjermsurawong/working-autogen * [ErrorProne fix: add @OverRide to enum get value][generated] source: spec3.sdk.yaml@non-master-spec-d9e92b9 in mickjermsurawong/working-autogen * [Rename Number to card details][generated] source: spec3.sdk.yaml@non-master-spec-c5dbddd in mickjermsurawong/working-autogen * [Sort setter methods][generated] source: spec3.sdk.yaml@non-master-spec-97a62f7 in gen-param-default * test: remove getters from params * test: create webhook with event enums * test: typed param addAll/putAll * [generated] source: spec3.sdk.yaml@non-master-spec-6e9fab7 in mickjermsurawong/default-gen-param

@OverRide

* test: typed param setup - fix ambiguous call with null casting test: CardTest ambiguous call with typed param * Basic primitives for typed params (#679) * extract common deserializer method extract common logic * implement ApiParamRequest add api param request * Add to base test lenient request params comparison for list/array int/long comparison * use List<Object> instead of Object[] in untyped deserializer * provide documentation to deserializer and api request param * reorder import statments * fix other imports in new files * test: Standardization consider request param as map param * rename and add more test (#718) * Fix remaining ErrorProne warnings * Verify deserialized boolean params to map (#722) * verify boolean behavior * add suppress warning * Generated for V9.0 [generated] source: spec3.sdk.yaml@non-master-spec-fb07de8 in mickjer… (#711) * test: typed params path query expand and limit * test: typed params on methods previously had params as string constant * test: typed params on polymoprhic of EMPTY and array test: use new empty param * test: typed params on inner object * test: typed params by collection methods * test: typed param fix to singular * test: typed param create token with different instruments test: Token with ObjectType enum test: typed params create token * test: typed params create charge test: typed params charge * generated: param * generated: model * generated: param * [generated] source: spec3.sdk.yaml@non-master-spec-d9e92b9 in mickjermsurawong/working-autogen * [ErrorProne fix: add @OverRide to enum get value][generated] source: spec3.sdk.yaml@non-master-spec-d9e92b9 in mickjermsurawong/working-autogen * [Rename Number to card details][generated] source: spec3.sdk.yaml@non-master-spec-c5dbddd in mickjermsurawong/working-autogen * [Sort setter methods][generated] source: spec3.sdk.yaml@non-master-spec-97a62f7 in gen-param-default * test: remove getters from params * test: create webhook with event enums * test: typed param addAll/putAll * [generated] source: spec3.sdk.yaml@non-master-spec-6e9fab7 in mickjermsurawong/default-gen-param

@OverRide

* test: typed param setup - fix ambiguous call with null casting test: CardTest ambiguous call with typed param * Basic primitives for typed params (#679) * extract common deserializer method extract common logic * implement ApiParamRequest add api param request * Add to base test lenient request params comparison for list/array int/long comparison * use List<Object> instead of Object[] in untyped deserializer * provide documentation to deserializer and api request param * reorder import statments * fix other imports in new files * test: Standardization consider request param as map param * rename and add more test (#718) * Fix remaining ErrorProne warnings * Verify deserialized boolean params to map (#722) * verify boolean behavior * add suppress warning * Generated for V9.0 [generated] source: spec3.sdk.yaml@non-master-spec-fb07de8 in mickjer… (#711) * test: typed params path query expand and limit * test: typed params on methods previously had params as string constant * test: typed params on polymoprhic of EMPTY and array test: use new empty param * test: typed params on inner object * test: typed params by collection methods * test: typed param fix to singular * test: typed param create token with different instruments test: Token with ObjectType enum test: typed params create token * test: typed params create charge test: typed params charge * generated: param * generated: model * generated: param * [generated] source: spec3.sdk.yaml@non-master-spec-d9e92b9 in mickjermsurawong/working-autogen * [ErrorProne fix: add @OverRide to enum get value][generated] source: spec3.sdk.yaml@non-master-spec-d9e92b9 in mickjermsurawong/working-autogen * [Rename Number to card details][generated] source: spec3.sdk.yaml@non-master-spec-c5dbddd in mickjermsurawong/working-autogen * [Sort setter methods][generated] source: spec3.sdk.yaml@non-master-spec-97a62f7 in gen-param-default * test: remove getters from params * test: create webhook with event enums * test: typed param addAll/putAll * [generated] source: spec3.sdk.yaml@non-master-spec-6e9fab7 in mickjermsurawong/default-gen-param

@OverRide

* Drop support for Java 1.7 * Upgrade dev dependencies (except JUnit) * Upgrade to JUnit 5 * Use ErrorProne in builds * Return unsafe deserialized event data object as Option (#723) * return as option * update doc * Autogen params (#705) * test: typed param setup - fix ambiguous call with null casting test: CardTest ambiguous call with typed param * Basic primitives for typed params (#679) * extract common deserializer method extract common logic * implement ApiParamRequest add api param request * Add to base test lenient request params comparison for list/array int/long comparison * use List<Object> instead of Object[] in untyped deserializer * provide documentation to deserializer and api request param * reorder import statments * fix other imports in new files * test: Standardization consider request param as map param * rename and add more test (#718) * Fix remaining ErrorProne warnings * Verify deserialized boolean params to map (#722) * verify boolean behavior * add suppress warning * Generated for V9.0 [generated] source: spec3.sdk.yaml@non-master-spec-fb07de8 in mickjer… (#711) * test: typed params path query expand and limit * test: typed params on methods previously had params as string constant * test: typed params on polymoprhic of EMPTY and array test: use new empty param * test: typed params on inner object * test: typed params by collection methods * test: typed param fix to singular * test: typed param create token with different instruments test: Token with ObjectType enum test: typed params create token * test: typed params create charge test: typed params charge * generated: param * generated: model * generated: param * [generated] source: spec3.sdk.yaml@non-master-spec-d9e92b9 in mickjermsurawong/working-autogen * [ErrorProne fix: add @OverRide to enum get value][generated] source: spec3.sdk.yaml@non-master-spec-d9e92b9 in mickjermsurawong/working-autogen * [Rename Number to card details][generated] source: spec3.sdk.yaml@non-master-spec-c5dbddd in mickjermsurawong/working-autogen * [Sort setter methods][generated] source: spec3.sdk.yaml@non-master-spec-97a62f7 in gen-param-default * test: remove getters from params * test: create webhook with event enums * test: typed param addAll/putAll * [generated] source: spec3.sdk.yaml@non-master-spec-6e9fab7 in mickjermsurawong/default-gen-param * Update doc on previous attributes array representation (#726) * update doc about array representation * fix another typo * Another dependency version bump * Fix docs on getting stripe object from `EventDataObjectDeserializer` (#727) * update docs on get object * Add missing Javadoc * Add non-autogen typed params Event/File/EphemeralKeys (#730) * file create params with handling of file object * create file with typed params * list file with typed params update import order on files refactor file test * add ephemeral key create params * add event list params * null check for typed parameters

mickjermsurawong-stripe force-pushed the mickjermsurawong/sdk-autogen-java-non-master-spec-fb07de8_2 branch from 95ffa8b to 406974c Compare March 29, 2019 14:57