Upgrade to JUnit 5 #706
Merged
Upgrade to JUnit 5 #706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remi-stripe
assigned
mickjermsurawong-stripe and unassigned
mickjermsurawong-stripe and
remi-stripe
Contributor
|
yay thank you @ob-stripe for the change! |
Contributor
Author
|
Thanks Mick! Some of our tests are flaky on Travis... It's nothing new, but we should look into it at some point, having to trigger rebuilds is annoying. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @mickjermsurawong-stripe @remi-stripe
cc @stripe/api-libraries
Upgrade to JUnit 5.
Lots of noise here, sorry! The main changes are:
org.junit.Assert->org.junit.jupiter.api.AssertionsassertTrueandassertSamenow take the failed assertion message as their last argument instead of their firstassertThrows