Drop support for Java 1.7 #698
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remi-stripe
approved these changes
Mar 20, 2019
Contributor
remi-stripe
left a comment
remi-stripe
left a comment
There was a problem hiding this comment.
The PR looks great so approving. Technically, 1.7 is still the second most used java version by our users, so we should be mindful of that and confirm that most 1.7 users are not even on 7.X for example.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @mickjermsurawong-stripe @remi-stripe
cc @stripe/api-libraries
Drop support for Java 1.7. This PR targets the
integration-v9branch, i.e. the next major version as this is a breaking change for users still running Java 1.7.I've removed the entire
StripeSslSocketFactoryclass: Java 1.8 uses TLS 1.2 by default, so we no longer need to set specific TLS settings. I've also removed all the AppEngine specific code: according to this page, when running on Java 8, AppEngine uses the standard Java classes.Dropping support for Java 1.7 will also allow us to upgrade several dev dependencies, in particular Gradle, and will let us support the newly released Java 12.
Tentatively fixes #562.