[payment methods] source: spec3.sdk.yaml@spec-9d9decd in master #690

mickjermsurawong-stripe · 2019-03-16T02:34:04Z

This PR contains the generated payment method apis.
It sadly just got the most updated Terminal endpoints that are incorrect now, but I think it's helpful if the PM features get reviewed or can help to the non-autogen one..
r? @remi-stripe
cc @stripe/api-libraries

mickjermsurawong-stripe · 2019-03-16T02:34:52Z

src/main/java/com/stripe/model/terminal/Location.java

    String url = String.format("%s%s", Stripe.getApiBase(), "/v1/terminal/locations");
    return requestCollection(url, params, LocationCollection.class, options);
  }
+


Terminal endpoints below actually would be correct, but it's not consistent. The client metadata now generate static methods

Do you think we want to release this as 8.0 too?

Yeah, we need to quickly talk about static methods (globally, not just java) because I think this is becoming critical. I also need to release those in the libs so it's on my todo list

remi-stripe

Left some comments but this looks great

remi-stripe · 2019-03-16T02:36:23Z

src/main/java/com/stripe/model/Charge.java

+
+      /** Check results by Card networks on Card address and CVC at time of payment. */
+      @SerializedName("checks")
+      Checks checks;


In this world we're not sharing with PaymentMethod.Card.Checks. In my PR I'm sharing because I assumed it was the same resource.

It's likely easier to not share but I'll need to update my PR so wanted to ask what you think is preferred?

Okay I saw the commend in my other PR too. I'll fix mine to just duplicate the class instead of trying to be smart.

@remi-stripe, I would prefer not sharing in this example, simply because it is what the back-end actually has. So I stated before that now we prefer sharing, I'm actually wrong. I think I was saying that because in most case backend code do share resources. So my position is rather resource sharing just as what our backend and open API has.

In the world that we share nothing, that's when we can ignore the backend code and openAPI references (with exceptions of sharinging core resource)

remi-stripe · 2019-03-16T02:40:33Z

src/main/java/com/stripe/model/Charge.java

+  /** Transaction-specific details of the payment method used in the payment. */
+  @SerializedName("payment_method_details")
+  PaymentMethodDetails paymentMethodDetails;
+


We're missing billing_details which is also shipping at the same time as payment_method_details. I realize it's also missing in my PRs though and I'll have to fix this but I think it's important to fix in pay-server

remi-stripe · 2019-03-16T02:41:22Z

src/main/java/com/stripe/model/PaymentMethod.java

+    @Setter
+    @EqualsAndHashCode(callSuper = false)
+    public static class ThreeDSecureUsage extends StripeObject {
+      /** 3D Secure is support on this card. */


typo in the comment

remi-stripe · 2019-03-16T02:44:28Z

src/main/java/com/stripe/model/terminal/Location.java

    String url = String.format("%s%s", Stripe.getApiBase(), "/v1/terminal/locations");
    return requestCollection(url, params, LocationCollection.class, options);
  }
+


Yeah, we need to quickly talk about static methods (globally, not just java) because I think this is becoming critical. I also need to release those in the libs so it's on my todo list

mickjermsurawong-stripe · 2019-03-16T03:16:35Z

Thanks remi for the review, I'll wait for billing details and will add to this PR then.

mickjermsurawong-stripe · 2019-03-18T18:56:20Z

I'm merging PM changes in first. There are 3 pending issues in the subsequent PR

Undashboard billing details so it appears on the spec, fix typo on 3D secure support, in this pay-sever #137513
Update terminal client metadata endpoints to reflect instance method #137444
Remove deprecated endpoints + checkout

* remove updated resource * src: remove class specific deserializers from ApiResource.java * test: use PaymentSource instead of ExternalAccount for BankAccount and Card in `/v1/customers/...` * test: remove Charge `markSafe/markFraudulent` method in favor of normal update * test: remove LoginLinkCollection for create method, in favor of LoginLink `craeteOnAccount` * test: rename Reversal to TransferReversal Reversal to Transfer Reversal * test: remove UsageRecord `create` taking ID argument in parameters, in favor of `createOnSubscriptionItem` * test: use StripeError and PaymentSource for PaymentIntent instead of PaymentIntentLastPaymentError and ExternalAccount * test: remove `getTypeData` in SourceTransaction and SourceMandateNotification in favor of new typed classes specific to each source type * test: use normal getters for auto-expand issuing.Card in Authorization and CardDetails instead of expandable idiom * test: fix Topup test using incorrect stripe-mock url * test: add deserialzation tests for unknown subtypes on BalanceTransactionSource and ExternalAccount * test: type-cast nulls for ambiguous method calls supporting single argument for both RequestOptions and param Map * src/test: [version-pin] pin API_VERSION and update RequestOptions and EphemeralKey * remove resources to be regenerated * test: add deserialization test to OrderItem expanding parent * "[generated] source: spec3.sdk.yaml@spec-214186957a2324edd15aba2a7d8d03e408f22669 in master"" * src/test: [version-pin] remove Stripe.apiVersion * Interface for handling event deserialization failure due to api version mismatch (#664) * make event data backward compat * implement versioned data * rename work * rename exception * improve deserializeUnsafeWith * add comments using static pinned version * "[generated] source: spec3.sdk.yaml@spec-c6ce0ce334c19193dc22b6b63f47388f25f30d57 in master"" (#666) * "[generated] source: spec3.sdk.yaml@spec-3b52a80 in master"" (#668) * remove resource * remove updated resource * remove updated resource * remove resources * [generated] source: spec3.sdk.yaml@non-master-spec-a8fea08 in HEAD (#671) * [generated] source: spec3.sdk.yaml@non-master-spec-d2b863d in mickjermsurawong/subscription-schedules (#672) * test: Person remove old document expansion * test: Subscription default source becomes PaymentSource * test: typed param setup - fix ambiguous call with null casting test: CardTest ambiguous call with typed param * test: LegalEntity class is removed fix person * Basic primitives for typed params (#679) * extract common deserializer method extract common logic * implement ApiParamRequest add api param request * Add to base test lenient request params comparison for list/array int/long comparison * use List<Object> instead of Object[] in untyped deserializer * provide documentation to deserializer and api request param * reorder import statments * fix other imports in new files * fix: RequestOptions use lombok equal/hashcode instead * test: Standardization consider request param as map param * Update resources to 8.0-beta (#687) * [generated] source: spec3.sdk.yaml@non-master-spec-e27a05e in mickjermsurawong/no-v-change * [generated] source: spec3.sdk.yaml@spec-82bb471 in master * [generated] source: spec3.sdk.yaml@spec-3869a7f in master * [generated] source: spec3.sdk.yaml@non-master-spec-02ef86a in mickjermsurawong/undoc-sensitive-enum * Revert "test: Standardization consider request param as map param" This reverts commit c3c1157. * Revert "Basic primitives for typed params (#679)" This reverts commit a1c2175. * Revert "test: typed param setup - fix ambiguous call with null casting" This reverts commit 1eb0f45. * [generated] source: spec3.sdk.yaml@spec-9d9decd in master (#690) * [generated] source: spec3.sdk.yaml@spec-2662e57 in master (#692) * [generated] source: spec3.sdk.yaml@spec-436464f in master (#693) * remove parts that should be done by script (#696)

[generated] source: spec3.sdk.yaml@spec-9d9decd in master

28258d6

stripe-ci assigned remi-stripe Mar 16, 2019

mickjermsurawong-stripe commented Mar 16, 2019

View reviewed changes

remi-stripe approved these changes Mar 16, 2019

View reviewed changes

stripe-ci added the approved label Mar 16, 2019

stripe-ci assigned mickjermsurawong-stripe and unassigned remi-stripe Mar 16, 2019

stripe-ci removed the approved label Mar 16, 2019

mickjermsurawong-stripe force-pushed the mickjermsurawong/sdk-autogen-java-spec-9d9decd branch from 771eeb1 to 28258d6 Compare March 18, 2019 18:51

mickjermsurawong-stripe changed the title ~~[payment methods][generated] source: spec3.sdk.yaml@spec-9d9decd in master~~ [payment methods] source: spec3.sdk.yaml@spec-9d9decd in master Mar 18, 2019

mickjermsurawong-stripe added the approved label Mar 18, 2019

mickjermsurawong-stripe merged commit d683cf3 into autogen/8.0-beta Mar 18, 2019

mickjermsurawong-stripe added a commit that referenced this pull request Mar 19, 2019

[generated] source: spec3.sdk.yaml@spec-9d9decd in master (#690)

a33d2f7

mickjermsurawong-stripe added a commit that referenced this pull request Mar 19, 2019

[generated] source: spec3.sdk.yaml@spec-9d9decd in master (#690)

581177e

mickjermsurawong-stripe deleted the mickjermsurawong/sdk-autogen-java-spec-9d9decd branch March 29, 2019 03:30

[payment methods] source: spec3.sdk.yaml@spec-9d9decd in master #690

[payment methods] source: spec3.sdk.yaml@spec-9d9decd in master #690

Uh oh!

Conversation

mickjermsurawong-stripe commented Mar 16, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

remi-stripe left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mickjermsurawong-stripe commented Mar 16, 2019

Uh oh!

mickjermsurawong-stripe commented Mar 18, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants