Update resources to 8.0-beta #687

mickjermsurawong-stripe · 2019-03-12T19:27:31Z

This PR only generates and update latest resources and without param changes.
I would like to merge this to branch 8.0-beta, and then rebase the pending params PR on to it (so review of PR and resource is separated)
r? @remi-stripe
cc @stripe/api-libraries

…msurawong/no-v-change

mickjermsurawong-stripe · 2019-03-12T19:28:02Z

src/main/java/com/stripe/model/Balance.java

+    @Getter
+    @Setter
+    @EqualsAndHashCode(callSuper = false)
+    public static class SourceTypes extends StripeObject {


Compatible with 7.x, 3rd level nesting

not sure what this comment means?

I meant that SourceTypes class now is nested inside Money, and inside Balance just as how 7.x has.

mickjermsurawong-stripe · 2019-03-12T19:29:23Z

src/main/java/com/stripe/model/Card.java

+   * service</a> without interruption.
   *
-   * <p>Update a specified source for a given customer.
+   * <p>Updates a specified card for a given customer.


This is updated in this PR #135080 in pay-server.

mickjermsurawong-stripe · 2019-03-12T19:30:23Z

src/main/java/com/stripe/model/Charge.java

+     * charge amount is transferred to the destination account.
+     */
+    @SerializedName("amount")
+    Long amount;


Same as the released 97b6e1a

mickjermsurawong-stripe · 2019-03-12T19:30:53Z

src/main/java/com/stripe/model/CountrySpec.java

+      /** Fields which every account must eventually provide. */
+      @SerializedName("minimum")
+      List<String> minimum;
+    }


Nesting compatible with 7.x

mickjermsurawong-stripe · 2019-03-12T19:31:32Z

src/main/java/com/stripe/model/Charge.java

+      @SerializedName("unit_cost")
+      Long unitCost;
+    }
+  }


Nesting compatible with 7.x

mickjermsurawong-stripe · 2019-03-12T19:32:16Z

src/main/java/com/stripe/model/Invoice.java

  ExpandableField<Customer> customer;

-  /** Time at which the object was created. Measured in seconds since the Unix epoch. */
-  @SerializedName("date")


Deprecated date and created is added.

mickjermsurawong-stripe · 2019-03-12T19:33:01Z

src/main/java/com/stripe/model/Invoice.java

  Long endingBalance;

-  /** The time that the invoice draft was finalized. */
-  @SerializedName("finalized_at")


Will use Status_transitions instead.
This is breaking, but I will have to document them again in the diff.

mickjermsurawong-stripe · 2019-03-12T19:34:43Z

src/main/java/com/stripe/model/Person.java

+  @Getter
+  @Setter
+  @EqualsAndHashCode(callSuper = false)
+  public static class Verification extends StripeObject {


Avedon related changes

mickjermsurawong-stripe · 2019-03-12T19:35:02Z

src/main/java/com/stripe/model/Source.java

 public class Source extends ApiResource implements PaymentSource, MetadataStore<Source> {
  @SerializedName("ach_credit_transfer")
-  SourceTypeAchCreditTransfer achCreditTransfer;
+  AchCreditTransfer achCreditTransfer;


Nesting of sources

mickjermsurawong-stripe · 2019-03-12T19:36:12Z

src/main/java/com/stripe/model/issuing/Settlement.java


+  /** The date that the transactions are cleared and posted to user's accounts. */
+  @SerializedName("clearing_date")
+  Long clearingDate;


Would like to flag this, as I didn't see it updated in 7.x

yeah they keep changing those and that was not API reviewed and I kind of punted on this one for now since it was coming with autogen

mickjermsurawong-stripe · 2019-03-12T19:36:23Z

src/main/java/com/stripe/model/reporting/ReportType.java


+  /** List of column names that are included by default when this Report Type gets run. */
+  @SerializedName("default_columns")
+  List<String> defaultColumns;


Same for this; I didn't see it updated in 7.x

yep this is new and was in the middle of API review so it's on my todo list

remi-stripe

thanks for flagging new things, this is really helpful. Left some comments but some are me misunderstanding that you're comparing to a previous 8.x beta branch and not master. I think it's mostly okay except some "secret" stuff (though not the bad ones so mostly okay)

remi-stripe · 2019-03-13T04:40:09Z

src/main/java/com/stripe/model/Balance.java

+    @Getter
+    @Setter
+    @EqualsAndHashCode(callSuper = false)
+    public static class SourceTypes extends StripeObject {


not sure what this comment means?

remi-stripe · 2019-03-13T04:42:57Z

src/main/java/com/stripe/model/EventDataClassLookup.java

    classLookup.put("issuing.authorization", Authorization.class);
    classLookup.put("issuing.card", com.stripe.model.issuing.Card.class);
    classLookup.put("issuing.card_details", CardDetails.class);
-    classLookup.put("issuing.card_pin", CardPin.class);


why did we remove this?

Ah autogen had CardPin class before, and I confirmed with the issuing team that it is not for our client-libs but the mobiles.

remi-stripe · 2019-03-13T04:43:43Z

src/main/java/com/stripe/model/Invoice.java


+  /** Time at which the object was created. Measured in seconds since the Unix epoch. */
+  @SerializedName("created")
+  Long created;


Why does this look added even though it's already in master per https://github.com/stripe/stripe-java/blob/master/src/main/java/com/stripe/model/Invoice.java#L32 ?

Yup it is comparing with the autogen branch, not the master

remi-stripe · 2019-03-13T04:45:30Z

src/main/java/com/stripe/model/PaymentIntent.java

+  /** The [Level III data](https://stripe.com/docs/level3) associated with this payment. */
  @SerializedName("level3")
-  Level3 level3;
+  Charge.Level3 level3;


I still believe we're making a mistake adding this in stripe-java. We should not support this until it's stable. Payflows used this like Charge but I believe they will change this. Not a huge deal but flagging again anyway

remi-stripe · 2019-03-13T04:47:02Z

src/main/java/com/stripe/model/Review.java

  Boolean open;

-  /** The reason the review was opened. One of `rule` or `manual`. */
+  /** The reason the review was opened. One of `rule`, `manual`, or `issuer_fraud_record`. */


technically the last one is supposed to be secret and should not be available publicly.

remi-stripe · 2019-03-13T04:48:24Z

src/main/java/com/stripe/model/Source.java


  @SerializedName("sepa_credit_transfer")
-  SourceTypeSepaCreditTransfer sepaCreditTransfer;
+  SepaCreditTransfer sepaCreditTransfer;


This is not public

remi-stripe · 2019-03-13T04:50:23Z

src/main/java/com/stripe/model/Source.java

+    String name;
+
+    @SerializedName("skip_validation")
+    Boolean skipValidation;


I don't think this is a thing

remi-stripe · 2019-03-13T04:51:37Z

src/main/java/com/stripe/model/issuing/CardPin.java

@@ -1,75 +0,0 @@
-// Generated by com.stripe.generator.entity.SdkBuilder


Not entirely sure why this disappeared though I'm not fully familiar with that resource

remi-stripe · 2019-03-13T04:52:07Z

src/main/java/com/stripe/model/issuing/Settlement.java


+  /** The date that the transactions are cleared and posted to user's accounts. */
+  @SerializedName("clearing_date")
+  Long clearingDate;


yeah they keep changing those and that was not API reviewed and I kind of punted on this one for now since it was coming with autogen

remi-stripe · 2019-03-13T04:52:27Z

src/main/java/com/stripe/model/reporting/ReportType.java


+  /** List of column names that are included by default when this Report Type gets run. */
+  @SerializedName("default_columns")
+  List<String> defaultColumns;


yep this is new and was in the middle of API review so it's on my todo list

mickjermsurawong-stripe · 2019-03-15T16:15:16Z

ptal @remi-stripe

skipValidation fields in Sources are now removed
PaperCheck and SepaCreditTransfer are removed. AchDebit remains as there's really no gate in backend, and it's supported in .NET and intended for .NET and Go
Remove level3 field from PaymentIntent

remi-stripe

approved but bumped 2 comments you skipped I think

remi-stripe · 2019-03-15T17:16:16Z

src/main/java/com/stripe/model/Review.java

  Boolean open;

-  /** The reason the review was opened. One of `rule` or `manual`. */
+  /** The reason the review was opened. One of `rule`, `manual`, or `issuer_fraud_record`. */


remi-stripe · 2019-03-15T17:16:21Z

src/main/java/com/stripe/model/Review.java

-   * The reason the review is currently open or closed. One of `rule`, `manual`, `approved`,
-   * `refunded`, `refunded_as_fraud`, or `disputed`.
+   * The reason the review is currently open or closed. One of `rule`, `manual`,
+   * `issuer_fraud_record`, `approved`, `refunded`, `refunded_as_fraud`, or `disputed`.


…msurawong/undoc-sensitive-enum

mickjermsurawong-stripe · 2019-03-15T18:24:55Z

my bad @remi-stripe! I did make assumption that the docs on enums were okay.
Fixed that.

mickjermsurawong-stripe · 2019-03-15T19:57:04Z

self-approving after fixing the doc comments.
LGTM

* [generated] source: spec3.sdk.yaml@non-master-spec-e27a05e in mickjermsurawong/no-v-change * [generated] source: spec3.sdk.yaml@spec-82bb471 in master * [generated] source: spec3.sdk.yaml@spec-3869a7f in master * [generated] source: spec3.sdk.yaml@non-master-spec-02ef86a in mickjermsurawong/undoc-sensitive-enum

* remove updated resource * src: remove class specific deserializers from ApiResource.java * test: use PaymentSource instead of ExternalAccount for BankAccount and Card in `/v1/customers/...` * test: remove Charge `markSafe/markFraudulent` method in favor of normal update * test: remove LoginLinkCollection for create method, in favor of LoginLink `craeteOnAccount` * test: rename Reversal to TransferReversal Reversal to Transfer Reversal * test: remove UsageRecord `create` taking ID argument in parameters, in favor of `createOnSubscriptionItem` * test: use StripeError and PaymentSource for PaymentIntent instead of PaymentIntentLastPaymentError and ExternalAccount * test: remove `getTypeData` in SourceTransaction and SourceMandateNotification in favor of new typed classes specific to each source type * test: use normal getters for auto-expand issuing.Card in Authorization and CardDetails instead of expandable idiom * test: fix Topup test using incorrect stripe-mock url * test: add deserialzation tests for unknown subtypes on BalanceTransactionSource and ExternalAccount * test: type-cast nulls for ambiguous method calls supporting single argument for both RequestOptions and param Map * src/test: [version-pin] pin API_VERSION and update RequestOptions and EphemeralKey * remove resources to be regenerated * test: add deserialization test to OrderItem expanding parent * "[generated] source: spec3.sdk.yaml@spec-214186957a2324edd15aba2a7d8d03e408f22669 in master"" * src/test: [version-pin] remove Stripe.apiVersion * Interface for handling event deserialization failure due to api version mismatch (#664) * make event data backward compat * implement versioned data * rename work * rename exception * improve deserializeUnsafeWith * add comments using static pinned version * "[generated] source: spec3.sdk.yaml@spec-c6ce0ce334c19193dc22b6b63f47388f25f30d57 in master"" (#666) * "[generated] source: spec3.sdk.yaml@spec-3b52a80 in master"" (#668) * remove resource * remove updated resource * remove updated resource * remove resources * [generated] source: spec3.sdk.yaml@non-master-spec-a8fea08 in HEAD (#671) * [generated] source: spec3.sdk.yaml@non-master-spec-d2b863d in mickjermsurawong/subscription-schedules (#672) * test: Person remove old document expansion * test: Subscription default source becomes PaymentSource * test: typed param setup - fix ambiguous call with null casting test: CardTest ambiguous call with typed param * test: LegalEntity class is removed fix person * Basic primitives for typed params (#679) * extract common deserializer method extract common logic * implement ApiParamRequest add api param request * Add to base test lenient request params comparison for list/array int/long comparison * use List<Object> instead of Object[] in untyped deserializer * provide documentation to deserializer and api request param * reorder import statments * fix other imports in new files * fix: RequestOptions use lombok equal/hashcode instead * test: Standardization consider request param as map param * Update resources to 8.0-beta (#687) * [generated] source: spec3.sdk.yaml@non-master-spec-e27a05e in mickjermsurawong/no-v-change * [generated] source: spec3.sdk.yaml@spec-82bb471 in master * [generated] source: spec3.sdk.yaml@spec-3869a7f in master * [generated] source: spec3.sdk.yaml@non-master-spec-02ef86a in mickjermsurawong/undoc-sensitive-enum * Revert "test: Standardization consider request param as map param" This reverts commit c3c1157. * Revert "Basic primitives for typed params (#679)" This reverts commit a1c2175. * Revert "test: typed param setup - fix ambiguous call with null casting" This reverts commit 1eb0f45. * [generated] source: spec3.sdk.yaml@spec-9d9decd in master (#690) * [generated] source: spec3.sdk.yaml@spec-2662e57 in master (#692) * [generated] source: spec3.sdk.yaml@spec-436464f in master (#693) * remove parts that should be done by script (#696)

[generated] source: spec3.sdk.yaml@non-master-spec-e27a05e in mickjer…

6ff49aa

…msurawong/no-v-change

mickjermsurawong-stripe commented Mar 12, 2019

View reviewed changes

stripe-ci assigned remi-stripe Mar 12, 2019

remi-stripe approved these changes Mar 13, 2019

View reviewed changes

stripe-ci added the approved label Mar 13, 2019

stripe-ci assigned mickjermsurawong-stripe and unassigned remi-stripe Mar 13, 2019

[generated] source: spec3.sdk.yaml@spec-82bb471 in master

239f569

stripe-ci removed the approved label Mar 15, 2019

[generated] source: spec3.sdk.yaml@spec-3869a7f in master

7287fc6

mickjermsurawong-stripe assigned remi-stripe and unassigned mickjermsurawong-stripe Mar 15, 2019

remi-stripe approved these changes Mar 15, 2019

View reviewed changes

stripe-ci added the approved label Mar 15, 2019

stripe-ci assigned mickjermsurawong-stripe and unassigned remi-stripe Mar 15, 2019

[generated] source: spec3.sdk.yaml@non-master-spec-02ef86a in mickjer…

89c74af

…msurawong/undoc-sensitive-enum

stripe-ci removed the approved label Mar 15, 2019

mickjermsurawong-stripe added the approved label Mar 15, 2019

mickjermsurawong-stripe merged commit ec2a54d into autogen/8.0-beta Mar 15, 2019

		@@ -1,75 +0,0 @@
		// Generated by com.stripe.generator.entity.SdkBuilder

Update resources to 8.0-beta #687

Update resources to 8.0-beta #687

Uh oh!

Conversation

mickjermsurawong-stripe commented Mar 12, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mickjermsurawong-stripe Mar 12, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

remi-stripe left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mickjermsurawong-stripe commented Mar 15, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

remi-stripe left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mickjermsurawong-stripe commented Mar 15, 2019

Uh oh!

mickjermsurawong-stripe commented Mar 12, 2019 •

edited

Loading

mickjermsurawong-stripe Mar 12, 2019 •

edited

Loading

mickjermsurawong-stripe commented Mar 15, 2019 •

edited

Loading