[wip] typed param example #680
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mickjermsurawong-stripe
commented
Feb 19, 2019
mickjermsurawong-stripe
commented
- This is illustrative PR to explain Basic primitives for typed params #679
- Please see the tests using the typed params in commit with message prefixed with "test:..."
|
|
||
| @Test | ||
| public void testCreateWithParams() throws StripeException { | ||
| SkuCreateParams.Inventory inventory = SkuCreateParams.Inventory.builder() |
Contributor
Author
There was a problem hiding this comment.
Inner inventory object passed as argument to the parent param builder.
| verifyRequest( | ||
| ApiResource.RequestMethod.POST, | ||
| String.format("/v1/invoices/%s", invoice.getId()), | ||
| paramsWithEmpty |
Contributor
Author
There was a problem hiding this comment.
Verify that "EMPTY" enums are serialized as nulls
| .addExpand("review") | ||
| .addExpand("source") | ||
| .addExpand("transfer_data.destination") | ||
| .build(); |
Contributor
Author
There was a problem hiding this comment.
Basic expand params
mickjermsurawong-stripe
force-pushed
the
mickjermsurawong/typed-param-example
branch
2 times, most recently
from
2e0e183 to
a648412
Compare
Contributor
|
OMG this is freaking awesome. Everyone using stripe-java is going to love you for this, haha. |
Contributor
Author
|
thanks @brandur-stripe! :) |
mickjermsurawong-stripe
force-pushed
the
mickjermsurawong/support-typed-params
branch
from
b5c3ee3 to
f22e048
Compare
mickjermsurawong-stripe
force-pushed
the
mickjermsurawong/typed-param-example
branch
from
a648412 to
f85f773
Compare
mickjermsurawong-stripe
force-pushed
the
mickjermsurawong/typed-param-example
branch
from
f85f773 to
793b24a
Compare
mickjermsurawong-stripe
force-pushed
the
mickjermsurawong/support-typed-params
branch
from
4add333 to
a2e28d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.