Implement Google's Error Prone in the build #494
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi @codylerum, thanks for the PR! This looks super interesting. We won't be able to merge this PR as is because it includes many different changes, some of which I suspect may be backwards-incompatible. Also, we're in the process of rewriting the test suite (cf. #452) and I'd rather avoid introducing merging more PRs that that affect the test codebase until we're done to avoid painful rebases. Once that's done though, I'm very much in favor of using this! I'm going to close this PR, but I'll open an issue to keep track of this. |
Closed
Contributor
Author
|
No problem. Let me do a second PR that fixes just the bugs that were identified. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements Googles Error Prone code analysis http://errorprone.info/
I’ve gone through and corrected the raised errors.
Error Prone cannot run on Java 7 and, as I am not a Gradle person, I don’t know how to conditionally run it. Thus the travis step for Java 7 is currently REMOVED. I would imagine that, like Checkstyle, you can configure this to only run for the Java 9 (or current latest) build.
http://errorprone.info/docs/installation
Per Google’s recommendation this is the Gradle plugin used:
https://github.com/tbroyer/Gradle-errorprone-plugin
I’ve also added an Eclipse Java style file that is based off Google’s Java style and tweaked to conform to your Checkstyle. It works for everything I’ve run into, so it’s probably a good starting point.
I would also recommend configuring error prone to fail on warning so that small issues don't creep in over time.