Skip to content

Add keyring dependencies to Debian package#1494

Merged
vcheung-stripe merged 2 commits intomasterfrom
vcheung-include-deps-in-deb-pkg
Mar 17, 2026
Merged

Add keyring dependencies to Debian package#1494
vcheung-stripe merged 2 commits intomasterfrom
vcheung-include-deps-in-deb-pkg

Conversation

@vcheung-stripe
Copy link
Copy Markdown
Collaborator

@vcheung-stripe vcheung-stripe commented Mar 17, 2026

Includes libsecret, gnome-keyring, libsecret-tools, and dbus-x11 as package dependencies for the Debian package to support secure credential storage.

Committed-By-Agent: claude

Reviewers

r? @
cc @stripe/developer-products

Summary

@vcheung-stripe @claude
Add keyring dependencies to Debian package
99087ed 
Includes libsecret, gnome-keyring, libsecret-tools, and dbus-x11 as package dependencies for the Debian package to support secure credential storage.

Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
Committed-By-Agent: claude
@vcheung-stripe vcheung-stripe requested a review from a team as a code owner March 17, 2026 23:27
@vcheung-stripe @claude
Fix field name for dependencies in nfpm config
72d3825 
Use 'dependencies' instead of 'depends' to match goreleaser's nfpm schema.

Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
Committed-By-Agent: claude
@vcheung-stripe vcheung-stripe merged commit a5cd1de into master Mar 17, 2026
14 checks passed
@vcheung-stripe vcheung-stripe deleted the vcheung-include-deps-in-deb-pkg branch March 17, 2026 23:36
@jsma
Copy link
Copy Markdown

jsma commented Mar 19, 2026

This change triggers the installation of the following packages on an Ubuntu 24.04 server:

The following NEW packages will be installed:
  adwaita-icon-theme at-spi2-common at-spi2-core dbus-x11 dconf-gsettings-backend dconf-service gcr gcr4 gnome-keyring gnome-keyring-pkcs11 gsettings-desktop-schemas
  gstreamer1.0-gl gstreamer1.0-plugins-base gtk-update-icon-cache hicolor-icon-theme humanity-icon-theme libatk-bridge2.0-0t64 libatk1.0-0t64 libatspi2.0-0t64
  libavahi-client3 libavahi-common-data libavahi-common3 libcairo-gobject2 libcairo-script-interpreter2 libcairo2 libcdparanoia0 libcolord2 libcups2t64 libdconf1
  libdrm-amdgpu1 libegl-mesa0 libegl1 libepoxy0 libgbm1 libgck-1-0 libgck-2-2 libgcr-4-4 libgcr-base-3-1 libgcr-ui-3-1 libgdk-pixbuf-2.0-0 libgdk-pixbuf2.0-bin
  libgdk-pixbuf2.0-common libgl1 libgl1-mesa-dri libgles2 libglvnd0 libglx-mesa0 libglx0 libgraphene-1.0-0 libgstreamer-gl1.0-0 libgstreamer-plugins-base1.0-0
  libgtk-3-0t64 libgtk-3-bin libgtk-3-common libgtk-4-1 libgtk-4-bin libgtk-4-common libgtk-4-media-gstreamer libllvm20 libogg0 libopus0 liborc-0.4-0t64
  libpam-gnome-keyring libpangocairo-1.0-0 libpixman-1-0 librsvg2-2 librsvg2-common libsecret-1-0 libsecret-common libsecret-tools libtheora0 libvisual-0.4-0 libvorbis0a
  libvorbisenc2 libvulkan1 libwayland-client0 libwayland-cursor0 libwayland-egl1 libx11-xcb1 libxcb-dri3-0 libxcb-glx0 libxcb-present0 libxcb-randr0 libxcb-render0
  libxcb-shm0 libxcb-sync1 libxcb-xfixes0 libxcomposite1 libxcursor1 libxdamage1 libxfixes3 libxi6 libxinerama1 libxrandr2 libxrender1 libxshmfence1 libxtst6 libxxf86vm1
  mesa-libgallium mesa-vulkan-drivers p11-kit p11-kit-modules pinentry-gnome3 session-migration ubuntu-mono x11-common

Previously this package had no external dependencies. I was alarmed while doing an apt upgrade to see so many GUI-related packages were set to be installed. Is it possible to use a more restrained set of dependencies to "support secure credential storage" without needing to install all of these packages (fonts, gstreamer, etc.)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@etsai2-stripe etsai2-stripe etsai2-stripe approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vcheung-stripe @jsma @etsai2-stripe