Attempt type conversion in assert.Equal#54
Merged
tylerstillwater merged 1 commit intostretchr:masterfrom Jun 4, 2014
jbowes:master
Merged
Attempt type conversion in assert.Equal#54tylerstillwater merged 1 commit intostretchr:masterfrom jbowes:master
tylerstillwater merged 1 commit intostretchr:masterfrom
jbowes:master
Conversation
If the two values being tested are of compatible types, convert one value to the other's type before comparing them. This allows `assert.Equal(int64(123), uint64(123))` to pass.
Contributor
|
Very nice! Thank you for the PR! |
tylerstillwater
pushed a commit
that referenced
this pull request
Jun 4, 2014
Attempt type conversion in assert.Equal
boekkooi-impossiblecloud
pushed a commit
to boekkooi-impossiblecloud/testify
that referenced
this pull request
Apr 16, 2026
Prepare/release v2.3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the two values being tested are of compatible types, convert one
value to the other's type before comparing them. This allows
assert.Equal(int64(123), uint64(123))to pass.