Skip to content

Conversation

@testwill
Copy link

@testwill testwill commented Jul 5, 2023

Summary

"io/ioutil" has been deprecated since Go 1.19: As of Go 1.16

Changes

Motivation

remove refs to deprecated io/ioutil

Related issues

@dolmen
Copy link
Collaborator

dolmen commented Jul 5, 2023

I think that testify is critical to the Go ecosystem. We must not block users from upgrading testify if they can't upgrade Go (example: removal of a GOARCH).
io/ioutil will stay forever (because of the Go 1 compatibility promise) so there is no immediate need for dropping its use.

So I think we must block this for now.

@dolmen dolmen added the revisit label Jul 5, 2023
@SuperQ
Copy link
Contributor

SuperQ commented Jul 5, 2023

We already have this problem by using Go modules (1.13), as well as specifying a minimum Go version in the go.mod as 1.19.

I haven't done an exhaustive search, but I'm guessing there are already features in use that make this unusable in older versions.

@SuperQ
Copy link
Contributor

SuperQ commented Jul 6, 2023

The CI tests are updated, so a rebase should show this is safe.

@dolmen dolmen added the dependencies Pull requests that update a dependency file label Jul 7, 2023
@testwill testwill closed this by deleting the head repository Jul 31, 2023
@dolmen dolmen added internal/refactor Refactor internals with no external visible changes and removed dependencies Pull requests that update a dependency file labels Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal/refactor Refactor internals with no external visible changes revisit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants