@nbaztec curious to get your feedback on this as you implemented most of the initial version of functional options support

I might've been too strict in ensuring that exactly the intended option is passed, ergo the explicit nature of providing the option name as well (which we removed as part of the original PR). As of now I cannot seem to think of a use-case where that might be absolutely necessary, as such if the other tests pass, perhaps we can go forward with it.

Hi @boyan-soubachov, could you please review this PR and provide feedback? It's currently blocking one of the primary use cases for testing functional options. Your insights would be greatly appreciated.

@dillonstreator Please rebase this PR as it includes gofmt 1.20 formatting changes that have already been applied. Those change pollute the diff and make reviewing harder.

@dolmen thanks for the heads-up - rebased 👍

Please don't merge master into your branch.

Instead:

git remote update
git rebase origin/master
git push -f

Please don't merge master into your branch.

Instead:

git remote update
git rebase origin/master
git push -f

@dolmen executing this wiped my changes

No more patch in this MR :(

The original patch is still available here: 1ec5341