Skip to content

Fix adding ? when no values passed #1320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dolmen merged 1 commit into from
Jul 11, 2023
Merged

Fix adding ? when no values passed #1320

dolmen merged 1 commit into from
Jul 11, 2023

Conversation

@lesichkovm
Copy link
Contributor

@lesichkovm lesichkovm commented Dec 22, 2022

Summary

Fix adding ? when no values passed

Changes

Small fix of incorrect URL generation

Motivation

When no values pased to the HTTPBody method, a ? is incorrectly added, when not essentially required

Related issues

dolmen
dolmen approved these changes Jul 11, 2023
View reviewed changes
Copy link
Collaborator

@dolmen dolmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dolmen dolmen added bug pkg-assert Change related to package testify/assert labels Jul 11, 2023
@dolmen dolmen self-assigned this Jul 11, 2023
@dolmen dolmen merged commit af4d8a6 into stretchr:master Jul 11, 2023
@renovate renovate bot mentioned this pull request Jun 3, 2024
Open
1 task
@renovate renovate bot mentioned this pull request Feb 18, 2025
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dolmen dolmen dolmen approved these changes

Assignees

@dolmen dolmen

Labels

bug pkg-assert Change related to package testify/assert

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lesichkovm @dolmen