Skip to content

Support comparing byte slice #1202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
boyan-soubachov merged 2 commits into from
Jun 21, 2022
Merged

Support comparing byte slice #1202

boyan-soubachov merged 2 commits into from
Jun 21, 2022

Conversation

@rleungx
Copy link
Contributor

@rleungx rleungx commented Jun 13, 2022

Signed-off-by: Ryan Leung [email protected]

Summary

Support comparing byte slice

Changes

Add byte slice in the compare function.

Motivation

func TestByteSlice(t *testing.T) {
	re := require.New(t)
	objs := [][]byte{[]byte("abc"), []byte("abcd"), []byte("abcde")}
	testcase := []byte("ab")

	for _, obj := range objs {
		re.Less(testcase, obj)
	}
}

Related issues

@rleungx rleungx marked this pull request as ready for review June 13, 2022 11:33
boyan-soubachov
boyan-soubachov reviewed Jun 20, 2022
View reviewed changes
boyan-soubachov
boyan-soubachov reviewed Jun 20, 2022
View reviewed changes
@rleungx
address the comment
4de1b4b 
Signed-off-by: Ryan Leung <[email protected]>
@rleungx rleungx requested a review from boyan-soubachov June 21, 2022 04:50
boyan-soubachov
boyan-soubachov approved these changes Jun 21, 2022
View reviewed changes
Copy link
Collaborator

@boyan-soubachov boyan-soubachov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution :)

@boyan-soubachov boyan-soubachov merged commit c31ea03 into stretchr:master Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boyan-soubachov boyan-soubachov boyan-soubachov approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rleungx @boyan-soubachov