Opening hours in compose#6691
Conversation
|
"no regular opening hours" seems to crash the app. |
|
Also: if you add months, then (accidentally) remove them, you cannot bring them "back" again: The "it differs by month" button does not do anything. Looks really cool though, nice work! |
|
Thanks for the bug reports! |
|
(I will be on vacation for several weeks starting after this weekend, so this PR will be open for some more time. I also plan to release a bugfix release before my vacation.) |
ok! will try to triage a bit more until then |
|
Alright, all done, including self-review. I'll merge it when I am back from vacation. |
|
That the popup menu / dropdown menu appears at the wrong location is somewhat... well, expected, or a known issue, see #6665 |
|
Just a quick point, while I'm out and about as well and wholly unable to read 3.8k changed lines (sorry!) This creates "open end" answers like 16:00-20:00+ because you can't not select a time picker answer in the "closing time" dialog. Is that intentional? There might simply be no "minimum opening hours that could be extended", which is how I would read the above example? Edit: oh, I'm supposed to pick the opening time as the closing time to get the result I was aiming for... This feels weird 🙃 K |
|
this works as before. If you specify the same start and end time, it will set it to e.g. 16:00+
El 20 de enero de 2026 20:59:36 GMT+04:00, Kai Michael Poppe ***@***.***> escribió:
…kmpoppe left a comment (streetcomplete/StreetComplete#6691)
Just a quick point, while I'm out and about as well and wholly unable to read 3.8k changed lines (sorry!)
https://github.com/streetcomplete/StreetComplete/blob/master/app%2Fsrc%2FcommonMain%2Fkotlin%2Fde%2Fwestnordost%2Fstreetcomplete%2Fosm%2Fopening_hours%2Fmodel%2FTimeRange.kt#L32-L43
This creates "open end" answers like 16:00-20:00+ because you can't not select a time picker answer in the "closing time" dialog. Is that intentional? There might simply be no "minimum opening hours that could be extended", which is how I would read the above example?
K
--
Reply to this email directly or view it on GitHub:
#6691 (comment)
You are receiving this because you authored the thread.
Message ID: ***@***.***>
|
This comment was marked as duplicate.
This comment was marked as duplicate.
|
@paulklie Yes, see #6691 (comment). |
Re-did in compose:
also fixes #6646, fixes #6175
Changes made to UI:
9:00-18:00for the first time for new weekdays, or one hour after the end of the previous time for existing weekdaysScreenshots
Re-survey

with months

dialogs (in Germany, with English locale)



(parking) fee form: maxstay and restricted by times
Screen_recording_20260119_000908.webm
Screen_recording_20260119_000935.webm