split up camp type into 2 quests and added cabin#6685
Merged
Conversation
Member
|
This seems to relate to #6676 though, no? Couldn't it be a checkbox list? |
Collaborator
Author
I did implement it that way intially. However I reconsidered a bit and I think I agree with #6447 (comment). The big advantage of splitting this quest up is that we can have different filters for each type:
|
Closed
westnordost
requested changes
Feb 5, 2026
…s/QuestsModule.kt
…s/camping/AddTents.kt
…s/camping/AddTents.kt
…s/camping/AddTents.kt
…s/camping/AddCabins.kt
Member
Well, I'd say 💩would fit. Twemoji has a fitting license (CC-BY-SA 4.0). The Google Noto Emoji looks better, but I am not sure about the license. |
westnordost
reviewed
Feb 5, 2026
westnordost
approved these changes
Feb 5, 2026
# Conflicts: # app/src/androidMain/kotlin/de/westnordost/streetcomplete/quests/camping/AddCampTypeForm.kt
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #6447
I have changed the following:
AddCaravansandAddTents.AddTentsalso now asked for tourism=caravan_siteAddCabinsquest for nonbackcountrycamp sites and caravan sites.Backcountry sites with tents=no (215 times) or caravans=yes (327 times), are not that rare. Additionally, as previously discussed these places are quite rare.
These quests require icons: