extended quests to castles#6670
Merged
Merged
Conversation
matkoniecz
reviewed
Dec 29, 2025
FloEdelmann
reviewed
Jan 2, 2026
| shop and shop !~ no|vacant | ||
| or amenity = social_facility and social_facility ~ food_bank|clothing_bank|soup_kitchen|dairy_kitchen | ||
| or natural = cave_entrance and fee = yes | ||
| or historic = castle and fee = yes |
Member
There was a problem hiding this comment.
Why not extend it to access = yes here, too?
Suggested change
| or historic = castle and fee = yes | |
| or historic = castle and (access = yes or fee=yes) |
Collaborator
Author
There was a problem hiding this comment.
I think most of those would be open24/7, thus this would be a bit spammy
matkoniecz
approved these changes
Jan 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends quests to historic=castle:
AddGeneralFee
Limited to
access=yes. Currently 546 castles are taggedfee=yesand 139fee=nothough I suspect that this tag is likely to be used more for ones that have a fee.AddOpeningHours
Currently tagged on 2.4% of castles. I have limited it to
fee=yes, to avoid asking for ones that are impossible to enter or to spammy (most would probably be 24/7).AddWheelchairAccessOutside
Similarly limited to
access=yes. Currently 3.86% of castles have this tag set.All tested.