Remove deflate compression from ContentEncoding#6628
Conversation
Removed deflate compression as server can reply as server can respond with zlib-wrapped DEFLATE format (RFC 1950) which is not supported by the io.ktor.client which I believe only supports raw DEFLATE.
|
Thanks! Have you tested the new app version? Sadly I am not able to test it right now - and not sure how to test it to avoid triggering rewrite rule, maybe change also user agent? |
|
No, I've not tested it. The dev server does not have the workarounds applied. |
|
No need to test, this will work. Thank you @Firefishy ! I wonder if this should be reported upstream (and that issue report be mentioned in a comment at that point in the code). I have to admit that I don't quite understand the cause of the issue yet. Just scanned the wikipedia article, which just has this to say:
So, |
|
(By the way, digged a bit into their code. On JVM, I end up here. Didn't dig deeper.) |
|
Turns out there is already an issue report. I added my reproduction. https://youtrack.jetbrains.com/issue/KTOR-6999/Deflate-ContentEncoder-incorrectly-uses-raw-DEFLATE |
Removed deflate compression as server can respond with zlib-wrapped DEFLATE format (RFC 1950) which is not supported by the io.ktor.client which I believe only supports raw DEFLATE.
Fixes: #6626