Skip to content

Recycling quest UI change#6615

Merged
westnordost merged 9 commits into
masterfrom
recycling-remade
Nov 13, 2025
Merged

Recycling quest UI change#6615
westnordost merged 9 commits into
masterfrom
recycling-remade

Conversation

@westnordost

@westnordost westnordost commented Nov 12, 2025

Copy link
Copy Markdown
Member

Make the list flat, but recognize which item is a subcategory of which other.

Fixes #6613

Also, fixes #6608

recycling2.mp4

@westnordost westnordost requested a review from mnalis November 12, 2025 18:39
Comment thread app/src/androidMain/res/values-en/strings.xml

@mnalis mnalis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While code itself is somewhat above my pay grade 😅 , the video solves #6613 and looks good.

Question: is the list going to autosorted by most-recently-used?

  • If it will auto-sort (hopefully), then it additionally improves usability a lot (I really disliked having to additionally click "any plastic" in 99% of the cases in old SC versions; it just wouldn't enter my muscle memory even if I entered it a lot - probably because all other recycling answers were single-click-for-answer)

  • if not, then, uh, need to scroll down all the time would not be nice sideeffect 😿

To me the new flat UI seems nicer (provided auto-sort mentioned above) and more efficient, and my wife also seemed to understand the concept of selecting some values (e.g. "PET bottles") deselecting its "parent" category (e.g. "any plastic") . While only anecdotal evidence, I hope other newbies will not be too confused either.

Other then that, only other potential confusion I see that "beverage cartons" are considered "plastic". Technically, they are multi-layer (e.g. plastic+paper+aluminium); but hopefully that is not confusing (it would not be a problem in Croatia, as we nowadays put them in same container as "any plastic" but I don't know if that might be confusing in other countries - e.g. if they are treated/collected differently then other plastic 🤷 )

@westnordost

Copy link
Copy Markdown
Member Author

it doesn't auto-sort, no. I think this would be confusing, as the sub-categories are all next to each other (behind each other)

@paulklie

Copy link
Copy Markdown
Collaborator

Tbh, I think this iteration is quite confusing, took me a good 3 min to find out how to use it. My main gripe:

It is not clear that the "only" elements only apply to plastic stuff. A bin that accepts, for example, plastic packaging and paper might cause a user to not select "plastic packaging only" since they misunderstand what it is asking.

@paulklie

Copy link
Copy Markdown
Collaborator

How about separating the plastic into:

  • PET bottles
  • Plastic bottles
  • Drink cartons
  • Plastic packaging
  • Other, non packaging, plastic

And allowing multiple to be selected.

@westnordost

Copy link
Copy Markdown
Member Author

It is not clear that the "only" elements only apply to plastic stuff. A bin that accepts, for example, plastic packaging and paper might cause a user to not select "plastic packaging only" since they misunderstand what it is asking.

It doesn't say "plastic packaging only", it says "any plastic packaging"

@westnordost

Copy link
Copy Markdown
Member Author

Other, non packaging, plastic

It is not really possible to tag that. It would complicate things a lot.

@paulklie

Copy link
Copy Markdown
Collaborator

It is not really possible to tag that. It would complicate things a lot.

Would that not be
recycling:plastic=yes
recycling:plastic_packaging=no

@westnordost

Copy link
Copy Markdown
Member Author

Yeah, probably. (But my statement that it complicates things stands.)

@mnalis

mnalis commented Nov 12, 2025

Copy link
Copy Markdown
Member

TL;DR: I'd prefer either new UI with auto-sort, or (if that is not possible) then retaining old UI instead.


it doesn't auto-sort, no.

Uh, that is quite unfortunate. 😢 Because, many of the shown features either:

  • do not exist in Croatia at all (e.g. plastic packaging only, plastic bottles only, beverage cartons only, shoes, food waste, ...), or
  • are extremely rare (i.e. mostly only in recycling centers, not regular containers) e.g. any glass, scrap metal, batteries, electric appliances, cooking oil, engine oil, ...
    And for recycling centers, the quest is unusable and I always need to leave a note anyway - as they take a lot of other unselectable things too (like paints, rubber, wood planks, medicines, rubble, asbestos etc. )

E.g. over here in 98% of the cases are just combination of 4 things: "glass bottles and jars", "paper", "any plastic"+"cans" (we put them in same container, i.e. recycling:pmd=yes1), "compostable waste".

Having those at top would be extremely helpful; while having them interspersed with things that do not exist here (and having to scroll down and search for things that are extremely common) is not a very pleasurable UX 🤷‍♂️

I think this would be confusing, as the sub-categories are all next to each other (behind each other)

I get the reasoning, but it doesn't work all that well when those things do not exist, IMHO.

And it is not perfect even when they are one after another as shown in video, due to splitting into multiple rows, so the confusion is still there IMHO (as noted by @paulklie ).

Anyway, if auto-sort is no-go, then I think UI used in previous versions of SC (even with its shortcomings) would be preferable to the new UI (both for yours [i.e. it would be more understandable for newbies], and for mine [i.e. easier for regular users to use] use cases).

Footnotes

  1. however, as PMD is not offered, we have to remember to select "any plastic" + "cans" answers separately, which is often forgotten (even my myself 😿), as we call them just "container for plastic", so when you mentally check off that one as marked, it is likely you'll forget about -- i.e. you've marked 3 items, and there are 3 containers, so that is "done" -- except it isn't 😢 .
    Having all of the common values one after another sorted at the top would make it much less likely to miss; and much easier to select appropriate containers.

@westnordost

westnordost commented Nov 12, 2025

Copy link
Copy Markdown
Member Author

Jesus, the time you have me invest in one quest...

@westnordost

Copy link
Copy Markdown
Member Author

I find pmd problematic because it is a tag that is essentially three different things at once: plastic packaging, drink cartons and metal (cans) packaging. So, one could say that pmd is a supercategory of these three things. But then, what is plastic? Also a supercategory of plastic packaging, but orthogonal to that! Argh!

@mnalis

mnalis commented Nov 13, 2025

Copy link
Copy Markdown
Member

TL;DR: I'd prefer if SC's recycling quest would allow for easy tagging in Croatia (e.g. by sorting and/or :pmd).
But it is not the end of the world if it doesn't.


I find pmd problematic because it is a tag that is essentially three different things at once

Yeah, I concur, but I didn't invent that tag just to complicate your life 😅 It just happens to describe how those containers operate in Croatia (even if we don't call it "PMD" but just colloquially "Plastic recycling containers") 🤷

The tagging situation here is very inconsistent (probably due to many tags being documented at different times, and not being offered by editors) - e.g. in Zagreb, where it is almost always one container for plastic+cans+tetrapak-alike-multilayered:

  • great majority of tagging uses just :plastic,
  • about 13% uses somewhat more correct combination :plastic+:cans,
  • significantly less that 0.1% use the actually correct :plastic + :cans + :beverage_cartons (or alternatively just :pmd)

Now, I would like if StreetComplete would help improve that tagging situation here. E.g. by:

  • Having a single click describe all three (regardless if it would tag 3 separate tags, or one PMD tag) is one helpful option, and/or
  • Having all commonly used values sorted at top is another

But having 3 different values that all have to be selected to mark one container, and especially having those values interspersed all around the scrollable list full of options that don't exist in Croatia, would IMHO be quite unlikely to improve the situation (to say the least) 🤷‍♂️

Jesus, the time you have me invest in one quest...

Well, yeah, sorry, but you specifically asked for my opinion 😉

As the saying goes "People don't want to hear your opinion. They want to hear their opinion, coming out of your mouth" 😃
Just joking! But do rest assured, that we all do hugely appreciate your effort, even if don't always get our way ❤️

@westnordost

westnordost commented Nov 13, 2025

Copy link
Copy Markdown
Member Author

You are right, it is not your job to consider effort (vs impact). I'm at the peculiar position to be both the developer - striving for code cleanliness, consistent UI design, - and product manager, having to look at effort vs impact.

Your comment about you preferring the previous solution unless I added that extra feature caught me on the wrong foot because it felt like an ultimatum (and I know, it wasn't) for both personas who were screaming "no" here: The solution in this PR is more consistent with UI elsewhere in the app while also cleaner on the technical side even though I had to invest more than one day's worth of work in that.

Anyway, I've looked into reordering and it wasn't that much extra work, so I just implemented that.

@westnordost

Copy link
Copy Markdown
Member Author

PMD

This is somewhat similar to the German system, by the way, known as "dual system", "green point" or "yellow sack"/"yellow container". However, there may be local differences. For example in Hamburg, the "yellow containers" also accept scrap metal and any plastic, not just packaging.

@westnordost westnordost merged commit 1b8a0f6 into master Nov 13, 2025
@FloEdelmann FloEdelmann deleted the recycling-remade branch November 13, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[v62.0-beta1] "any" plastic for recycling is now unclear "PET only" image is misleading

4 participants