Aerialway bicycle quest#6544
Conversation
Changing name of app to differenciate the main app and our changes
|
Might want to add an option "there is no sign" that tags aerialway:bicycle:signed=no. What do the others think? |
changing the bad value "-1" in "summer"
Set back the name of the application
updating the filter to choose the good aerialways for the quest
|
I also believe that AImageListQuestForm is probably not the best form type here since I don't think the images add much information. |
I have an issue with this situation. As I added a string for the summer answer, I don't know how to add properly my string in the Res file (the commonMain strings.xml). I want to do it because I am trying to follow the camping quest, such as you recommended me. Thank you in advance for your response. |
|
You always have to add your strings to the Sorry about that (duplication), we are currently migrating to another UI framework. That the strings are now duplicated into two directories is a temporary solution, as the new UI code uses the strings from commonMain and the old UI code uses the strings from androidMain. |
There was a problem hiding this comment.
Quite nice!
I have a few suggestions to improve it, though. But it is not necessary to improve it for this PR to be merged. (I may improve it myself, then).
- Grey on pink is not that well visible. I'd suggest to make the lift white (or another color).
- Also, the line of the aerialway car could span the whole icon, it doesn't need to be cut off before it reaches the outline of the circle.
- The icon would look more clean / less busy IMO if the bicycle was in the lift, i.e. a bicycle in a box that hangs off a line. I am not entirely sure if this would still be recognizable well as a lift without the "window". Something to try out.
- personal opinion: I like the yellow for the bicycle better, it mixes better with the pink background
- the shadow is inconsistent. IIRC the shadow of all icons is always exactly 4px under the icon itself (check other icons)
There was a problem hiding this comment.
I am thankful for all these suggestions. I am actually working with InkScape, and it doesn't allow me to insert a good shadow properly. As the aerialway is from SVG Repo, I am not allowed (except if I am wrong) to edit the "item", and thus, with the added white lines, the shadows are superimposed.
There was a problem hiding this comment.
what lisence is the original from svg repo under?
There was a problem hiding this comment.
The license is PD License, which means Public Domain License if I am not wrong
paulklie
added
the
new quest
…estnordost, deleting the unnecessary failes, and updating the answers of the quest
|
You forgot to include the .svg in your commit ;) |
Speaking of which, even if the license is public domain, it is better to add attribution (with link to source and license information) in any case. This is done in the authors.txt in the /res/graphics/ directory. |
|
I remade the quest icon to my liking. I wouldn't say that it is clearly better than yours, but there were open issues with it anyway (missing shadow, you didn't update the SVG) anyway, so I took this as an opportunity as a shortcut to further PR forth-and-back. (I removed the attribution to maki icons because I actually re-did the cabin - it's just a few lines anyway...) |
9 participants
Adding the following quests suggested in #6457:
For now, the icon of the quest is SVG handmade with an aerialway. There are yes/no svg for answers and a blue background with a sun if it's only during summer.