Skip to content

Motorcycle parking fee quest#6532

Merged
westnordost merged 32 commits into
streetcomplete:masterfrom
HugoTHOLLON:motorcycle_parking_fee
Oct 1, 2025
Merged

Motorcycle parking fee quest#6532
westnordost merged 32 commits into
streetcomplete:masterfrom
HugoTHOLLON:motorcycle_parking_fee

Conversation

@ElPoraz

@ElPoraz ElPoraz commented Sep 30, 2025

Copy link
Copy Markdown
Contributor

Adding the following quests suggested in #6457:

Do you have to pay to park your motorcycle here?

@paulklie paulklie left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work!

Comment thread app/src/commonMain/kotlin/de/westnordost/streetcomplete/ApplicationConstants.kt Outdated
@paulklie

Copy link
Copy Markdown
Collaborator

Good job with the icon btw! Maybe the coin could be moved to the left a bit so the "motorcycle" icon is a bit clearer?

@paulklie

Copy link
Copy Markdown
Collaborator

Also: please include the quest icon in a .svg format in https://github.com/streetcomplete/StreetComplete/tree/master/res/graphics/quest

@ElPoraz

ElPoraz commented Sep 30, 2025

Copy link
Copy Markdown
Contributor Author

Good job with the icon btw! Maybe the coin could be moved to the left a bit so the "motorcycle" icon is a bit clearer?

I just used the same icon as the one from the bicycle quest, but it's possible that it hides the motorcycle. Here are two other possible versions.

Coin on the left side:

image

Coin on the same place but the motocycle is reversed as the bicycle icon:

image

@paulklie

Copy link
Copy Markdown
Collaborator

I think @westnordost might be best to judge this, but I feel like the former is clearer.

@ElPoraz

ElPoraz commented Sep 30, 2025

Copy link
Copy Markdown
Contributor Author

Also: please include the quest icon in a .svg format in https://github.com/streetcomplete/StreetComplete/tree/master/res/graphics/quest

Sure, i wait for @westnordost opinion then i'll add it.

@westnordost westnordost left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you supply the quest icon also in SVG in /res/graphics/quest/motorcycle_parking_fee.svg ?

@westnordost

Copy link
Copy Markdown
Member

I find your first icon better because the motorcycle is visible better

@ElPoraz

ElPoraz commented Oct 1, 2025

Copy link
Copy Markdown
Contributor Author

Can you supply the quest icon also in SVG in /res/graphics/quest/motorcycle_parking_fee.svg ?

Yes, it's done.

@paulklie paulklie left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

@westnordost westnordost merged commit 38a3f5e into streetcomplete:master Oct 1, 2025
@riQQ riQQ added the new quest accepted new quest proposal (if marked as blocked, it may require upstream work first) label Oct 1, 2025
@paulklie

paulklie commented Oct 2, 2025

Copy link
Copy Markdown
Collaborator

@westnordost

westnordost commented Oct 2, 2025

Copy link
Copy Markdown
Member

This is not necessary. It's too small of a thing to claim copyright over, IMO. (But I don't mind if you do 🤷)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new quest accepted new quest proposal (if marked as blocked, it may require upstream work first)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants