AddLevelThing quest#6433
Conversation
|
It would definitely be necessary to highlight other things, too. E.g. there might be a bench at level 1 and 2 at basically the same location as the one one is asked for. When one switches through the levels, those on 1 and 2 must be visible, otherwise the user will add the wrong level. |
|
But it is anyway a good idea to also highlight shops, because this is necessary for orientation as the map itself is not helpful for indoor things. |
|
Regarding the icon, could just be the same icon as for the place level quest, but with an amenity-green background. |
Aye, thats what I added. |
The quest currently does not ask about benches though |
|
Hmm, I wonder if this could even be put into the The question text would need to be adapted. And things should maybe only be highlighted if the element that is asked for is also a thing. |
I see a few issues with this:
|
|
Right, I agree, especially on point 2. |
|
What do you think of also asking for things inside of shop=department_store? |
Done |
Other than toilets, I've no idea what one would want to map in a department store. I don't expect department stores to be indoor-mapped for each level. |
Hmm,I think aeds, first aid kits, phones, artwork, atms could all also be in department stores |
westnordost
left a comment
There was a problem hiding this comment.
I'd find it cleaner if there was one abstract AAddLevelForm and both forms would inherit from that. You'll find this is also consistent with the rest of the codebase (, as I consider inheritance of concrete classes messy).
westnordost
left a comment
There was a problem hiding this comment.
Good job! I found a few smallish things.
|
it seems that svg file was not committed: |
I never created a .svg, did not know it was needed. I only modified the .xml from the level quest to change the colour. |
|
It's not needed for the app but for that task that helps some people keep the documentation in the OpenStreetMap wiki up-to-date with the app. Also, since the Android drawable resources are somewhat of a proprietary format, it makes sense to keep the vector resources around in a format that can actually be easily edited. |
Fixes #6431