Skip to content

added quests to observation tower#6430

Merged
westnordost merged 3 commits into
streetcomplete:masterfrom
paulklie:observation_tower_quests
Aug 17, 2025
Merged

added quests to observation tower#6430
westnordost merged 3 commits into
streetcomplete:masterfrom
paulklie:observation_tower_quests

Conversation

@paulklie

@paulklie paulklie commented Aug 8, 2025

Copy link
Copy Markdown
Collaborator

fixes #6427

@paulklie

paulklie commented Aug 8, 2025

Copy link
Copy Markdown
Collaborator Author

The strings seem to generally fit, am only unsure with the wheelchair quest, what do you think: image

@paulklie paulklie marked this pull request as draft August 8, 2025 18:45
@westnordost

Copy link
Copy Markdown
Member

I think this is okay. The hint text for WheelchairAccessBusiness is certainly less well fitting ;-)

@paulklie paulklie marked this pull request as ready for review August 9, 2025 15:04

@westnordost westnordost left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, are there nodes with highway=steps? Seems wrong to me, I think it would be more clear if there were two filters.

@paulklie

Copy link
Copy Markdown
Collaborator Author

Hmm, are there nodes with highway=steps? Seems wrong to me, I think it would be more clear if there were two filters.

Sure, though there are less than 3k

@westnordost

Copy link
Copy Markdown
Member

Oh, that's weird. What is this supposed to be? Or is it a tagging error? The wiki doesn't mention it at all.

@paulklie

paulklie commented Aug 13, 2025

Copy link
Copy Markdown
Collaborator Author

Oh, that's weird. What is this supposed to be? Or is it a tagging error? The wiki doesn't mention it at all.

There has been some discussion on this topic (https://wiki.openstreetmap.org/wiki/Talk:Tag:highway%3Dsteps#nodes), and I think I agree that tagging ladders and single steps like this could be reasonable. Though I guess we could also ask the step question for these nodes right?

@westnordost

Copy link
Copy Markdown
Member

hm yeah, I guess we could

@paulklie

Copy link
Copy Markdown
Collaborator Author

Due to the query of the Opening Times quest, users will not be asked for the opening times of towers without a name. I don't think this is to big of an issue.
I don't think we should add observation towers to the name quest eater, since many towers don't have names (almost 70%).

@paulklie paulklie requested a review from westnordost August 14, 2025 21:51
2 spaces, inner () is not necessary but ok, for clarity
@westnordost westnordost merged commit a2aec7f into streetcomplete:master Aug 17, 2025
@matkoniecz

Copy link
Copy Markdown
Member

See https://community.openstreetmap.org/t/reporting-streetcomplete-issues/135672/3 - it looks like that there are tags that should cause this quest to be excluded for towers.

@paulklie

Copy link
Copy Markdown
Collaborator Author

See https://community.openstreetmap.org/t/reporting-streetcomplete-issues/135672/3 - it looks like that there are tags that should cause this quest to be excluded for towers.

Thanks for the pointer, as mentioned in the thread I will submit a patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expands quests to observation towers

4 participants