Reimplement Localized names + address in Compose#6403
Merged
Conversation
# Conflicts: # app/src/androidMain/kotlin/de/westnordost/streetcomplete/screens/settings/SettingsScreen.kt # app/src/androidMain/res/layout/quest_roadname_row.xml # app/src/androidMain/res/layout/row_localizedname.xml
# Conflicts: # app/src/androidMain/kotlin/de/westnordost/streetcomplete/quests/LengthForm.kt # app/src/androidMain/kotlin/de/westnordost/streetcomplete/ui/common/Button2.kt
# Conflicts: # app/src/androidMain/kotlin/de/westnordost/streetcomplete/screens/settings/SettingsScreen.kt
Member
Author
AddAddressStreetFormScreen_recording_20250820_133537.mp4 |
This reverts commit 65d73a7.
Member
Author
AddRoadNameForm, AddPlaceNameForm, AddBusStopNameFormScreen_recording_20250820_183152.mp4 |
Member
Author
AddressOverlayFormScreen_recording_20250820_191327.mp4 |
Member
Author
AddEntranceReferenceScreen_recording_20250821_201922.mp4 |
Member
Author
Places overlay(only the name part, this PR shall not grow into infinity) Screen_recording_20250823_001123.mp4 |
Member
Author
|
As follow-up: Should revisit the auto-sizing of TextField2, TextField2 is basically not able to apply Ready for review. |
Member
Author
|
Also as follow-up: drop auto-expand-abbreviations support. See #6416. (Should still contain hint that names should be expanded and should probably still warn user about not expanded abbreviations) |
westnordost
changed the title
github-project-automation
Bot
moved this from In Progress
to Done (unreleased)
in iOS Port
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
also fixes #5479