Skip to content

check for existence of bicycle repair stations#6397

Merged
westnordost merged 1 commit into
streetcomplete:masterfrom
paulklie:check_existance_bicycle_repair
Jul 13, 2025
Merged

check for existence of bicycle repair stations#6397
westnordost merged 1 commit into
streetcomplete:masterfrom
paulklie:check_existance_bicycle_repair

Conversation

@paulklie

@paulklie paulklie commented Jul 8, 2025

Copy link
Copy Markdown
Collaborator

Feels like a small enough map feature to fit into the existence quest. 4 years seemed like the most fitting category. bike repair stations that have not been updated for 4 years are currently quite rare though, mostly due to the new bike repair quest. However I found this node that can serve for testing: https://www.openstreetmap.org/node/6145704153#map=19/54.892393/9.550448&layers=C

@mnalis

mnalis commented Jul 8, 2025

Copy link
Copy Markdown
Member

Or perhaps AddBicycleRepairStationServices quest itself could be reasked every 4 years?

That would seem more useful for me, as repair stand might still be there, but pump stolen/broken for example (which is unfortunately quite common here)...

@paulklie

paulklie commented Jul 9, 2025

Copy link
Copy Markdown
Collaborator Author

I think such a reasking quest would be significantly more complicated:

  • What do we do with tools that were previously tagged yes and are damaged / gone? Simply set to no? Add destroyed: or was:?
  • Do we ask this quest if not all tools are set? eg. what if only service:bicycle:pump but not service:bicycle:tools are set?

@FloEdelmann FloEdelmann changed the title check for existance of bicycle repair stations check for existence of bicycle repair stations Jul 9, 2025
@matkoniecz

Copy link
Copy Markdown
Member

What do we do with tools that were previously tagged yes and are damaged / gone? Simply set to no? Add destroyed: or was:?

no, the same as with newly asked

Do we ask this quest if not all tools are set? eg. what if only service:bicycle:pump but not service:bicycle:tools are set?

I would ask as long as unsupported values are not present (maybe allow them if set to no?)

@paulklie

paulklie commented Jul 9, 2025

Copy link
Copy Markdown
Collaborator Author

I would ask as long as unsupported values are not present (maybe allow them if set to no?)

Hmm, I think we need a new ui design then, that shows the user not just yes/no of each tool as currently, but can also display a value as "undefined" so the user can understand where additional information is needed.

@matkoniecz

Copy link
Copy Markdown
Member

undefined is the same as set to no - right?

@paulklie

Copy link
Copy Markdown
Collaborator Author

undefined is the same as set to no - right?

Not for service:bicycle:tools which is implied to be no. Though I think this fact makes such a re asking quest even more appealing, since many bike repair stations that have only pumps (very common in my area) are not tagged with tools=no. See my original issue on the topic: #5870 (comment)

@westnordost

Copy link
Copy Markdown
Member

I agree with the others, it would make sense to re-ask the bicycle tools quest, but this does not exclude that repair stations' existence could not also be be asked.

@westnordost westnordost merged commit 20c8391 into streetcomplete:master Jul 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants