Skip to content

Import new tracktype_grade2 pictures from the wiki to show dirt#6242

Merged
westnordost merged 1 commit into
streetcomplete:masterfrom
Caerbannog:grade2-picture
May 25, 2025
Merged

Import new tracktype_grade2 pictures from the wiki to show dirt#6242
westnordost merged 1 commit into
streetcomplete:masterfrom
Caerbannog:grade2-picture

Conversation

@Caerbannog

Copy link
Copy Markdown
Contributor

This is similar to issue #2294 which was closed by 9dd1ddf.

Problem

The tracktype quest asks to select between grade1 and grade5.
The picture for grade2 (Mostly solid) is not clear in my opinion. When displayed on a medium screen, I had trouble to see the distinction with grade1 (Paved). The surface color and texture looked similar to asphalt/rocks.

Solution

This PR imports the grade2 reference picture from the wiki:
https://wiki.openstreetmap.org/wiki/Key:tracktype#Values

Result

Before After
image image

@matkoniecz

Copy link
Copy Markdown
Member

perspective/road position on this photo is noticeably different than on other (yes, I know how hard is too take matching images)

@westnordost

Copy link
Copy Markdown
Member

I agree with both of you. Can you find a picture that uses the same perspective but clearly shows some compacted surface?

@matkoniecz

Copy link
Copy Markdown
Member

argh, sorry to complain but this one looks quite sandy to me on tiny thumbnail (note: I was similarly complaining when I was selecting pictures on my own)

curiously, it is not a problem when I look at https://commons.wikimedia.org/wiki/File:Track_in_Schwinkendorf_2021-09-07_21.jpg

and maybe it will not be a problem given that description is there?

@westnordost

westnordost commented May 16, 2025

Copy link
Copy Markdown
Member

How about this one? It's the same track, only at a slightly different position. Due to the shadows cast by the trees, the surface doesn't look so yellow / sandish-ly, while the grass makes it clear that it is not paved:

https://commons.wikimedia.org/wiki/File:Track_in_Schwinkendorf_2021-09-07_20.jpg

By the way, this, also the same track at a slightly different position, maybe use to replace the current grade5 pic?:

https://commons.wikimedia.org/wiki/File:Track_in_Schwinkendorf_2021-09-07_04.jpg

By the way, I don't find the current picture for grade4 so good. On the thumbnail it looks much closer to grade5 than to grade3, even though it should be in the middle.

@westnordost westnordost added the feedback required more info is needed, issue will be likely closed if it is not provided label May 16, 2025
@Caerbannog

Copy link
Copy Markdown
Contributor Author

Great.
Here is a commit with the two links you posted.

Here is a screenshot in the Android simulator:
image

I have other things to say about the pictures (too small! hidden by text! who cares about the sky! grade1 season is confusing! irrelevant water puddles on grade3!). But at least it's a step forward.

@westnordost

Copy link
Copy Markdown
Member

Yes, about the text, I think this should be changed to text below the picture, not on top of it. For all quests. But yeah, that's a different ticket, and kind of currently blocked by a WIP PR.

Regarding "too small", I thought about being able to show a larger version of the picture by tapping on it (another time after selecting it), but that would be a major work, as that should then work for all of the pictures. It would also blow up the app size a lot, making it maybe worth it to think about not bundling those resources in the app but downloading+caching them after app install or something. Anyway, that's a bit more blue sky, and also anyway blocked by a WIP PR / near-future refactorings.

@westnordost westnordost removed the feedback required more info is needed, issue will be likely closed if it is not provided label May 16, 2025
@westnordost westnordost merged commit ff6cd88 into streetcomplete:master May 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants