Skip to content

add type of a ferry quest [ready to merge]#1432

Merged
westnordost merged 5 commits into
streetcomplete:masterfrom
matkoniecz:ferry
Jun 29, 2019
Merged

add type of a ferry quest [ready to merge]#1432
westnordost merged 5 commits into
streetcomplete:masterfrom
matkoniecz:ferry

Conversation

@matkoniecz

@matkoniecz matkoniecz commented Jun 19, 2019

Copy link
Copy Markdown
Member

fixes #39

Note that long ferries are excluded, like any long ways.

In this case quest will collect information that sometimes can be already derived from other data. But even if it collects data that changes routing only in 1% of solved quests it is still worth tagging it explicitly as incorrect routing caused by a poor ferry data may cause massive detours.

I looked at other access values and most of them are mistakes, foot=designated where foot=yes works equally well or extremely rare situations that can be handled with a note.

I am considering more complicated motor vehicle quest to handle cases where only some types of vehicles are allowed (say, only motorcycles). For now I trust user to switch to creating notes in such cases.


My work on this pull request was sponsored by a NGI Zero Discovery grant

Comment thread app/src/main/res/values/strings.xml Outdated
@matkoniecz matkoniecz changed the title add type of a ferry quest add type of a ferry quest [WIP] Jun 19, 2019
@matkoniecz matkoniecz changed the title add type of a ferry quest [WIP] add type of a ferry quest [WIP, retesting needed] Jun 19, 2019
@matkoniecz matkoniecz changed the title add type of a ferry quest [WIP, retesting needed] add type of a ferry quest [waiting for response how new icon version should be made, retesting needed] Jun 19, 2019
@matkoniecz matkoniecz mentioned this pull request Jun 20, 2019
to make water distinguishable from blue background, and keep water color the same on both
I made water color a bit darker
@matkoniecz matkoniecz changed the title add type of a ferry quest [waiting for response how new icon version should be made, retesting needed] add type of a ferry quest [ready for review] Jun 20, 2019
Comment thread app/src/main/res/drawable/ic_quest_ferry.xml

@westnordost westnordost left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will go into the next major version (because translation updates), which is why I am not merging this yet, but it is done.

@westnordost westnordost changed the title add type of a ferry quest [ready for review] add type of a ferry quest [ready to merge] Jun 21, 2019
@matkoniecz

Copy link
Copy Markdown
Member Author

I am still thinking about

I suggest "Are __ permitted to ride on %s?"

proposed by @goldfndr

"Are motor vehicles permitted to ride on %s?"

seems a bit weird to me, but maybe it is actually better

@westnordost

Copy link
Copy Markdown
Member

Sounds a little weird. One does not "ride" on a ferry.

@goldfndr

Copy link
Copy Markdown
Contributor

Perhaps it's just en-US? Or elsewhere? It's definitely "ride" in US:WA. (WSDOT has a fairly extensive ferry system locally; note that a paragraph starts with "Riders".)

@westnordost

westnordost commented Jun 22, 2019 via email

Copy link
Copy Markdown
Member

@matkoniecz

Copy link
Copy Markdown
Member Author

For me

"Are pedestrians permitted to ride on %s?"

seems perfectly fine. But

"Are motor vehicles permitted to ride on %s?"

also seems weird to me. @goldfndr - are you sure that this is OK?

@rugk

rugk commented Jun 22, 2019

Copy link
Copy Markdown
Contributor

Remember that @goldfndr is the only native English speaker in this issue here. 😃 With everything else, the translators then have to deal with these kind of issues… 😉

@matkoniecz

Copy link
Copy Markdown
Member Author

Remember that @goldfndr is the only native English speaker in this issue here

I know, but I wanted to ask explicitly about

"Are motor vehicles permitted to ride on %s?"

variant.

@goldfndr

Copy link
Copy Markdown
Contributor

I'm thinking that, rather than the awkward usage of "riding" for passenger vehicles (which, upon reflection, sounds a bit odd to me too), @matkoniecz's current wording is fine. (I was thinking boarding but that makes the question much longer.) But "this ferry" needs to be added to the strings that don't include "%s", as the questions are incomplete otherwise.

Oh, lest I forget again, StreetComplete tends to use the word "allowed" rather than "permitted". My apologies.

@matkoniecz

Copy link
Copy Markdown
Member Author

My apologies.

Nothing wrong happened! Review of wording and confirmation that it is OK is very useful. More than enough to outweigh slight confusion by proposing alternative wording and withdrawing it on a second thought.

@westnordost westnordost merged commit c26651c into streetcomplete:master Jun 29, 2019
@matkoniecz matkoniecz deleted the ferry branch June 29, 2019 20:43
Comment thread app/src/main/res/values/strings.xml
Comment thread app/src/main/res/drawable/ic_quest_ferry_pedestrian.xml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Type of Ferry quest

4 participants