Skip to content

marking shop=yes as vacant fails to remove shop-related-tags #6291

@mnalis

Description

@mnalis

Quest "What type of shop if this?" is used to add more specific shop type on shop=yes. That works fine when more specific shop is chosen (e.g. shop=clothes), but when it is answered that shop has gone in the meantime ("It's vacant" answer), SC fails to remove existing shop-related-tags as it should.

How to Reproduce

  • find a shop=yes which has extra shop tags, e.g. n6308237971
  • click on the Quest "What type of shop if this?"
  • Choose "It's vacant..." answer
  • note that it changes shop=yes to disused:shop=yes, but does not remove name=*

Expected Behavior
When shop=yes is marked as vacant, all keys in KEYS_THAT_SHOULD_BE_REMOVED_WHEN_PLACE_IS_REPLACED (like e.g. name=*) should be removed (e.g. like they are properly removed when in Places overlay one chooses "It's vacant")

Versions affected
StreetComplete v61.0, Android 14

Metadata

Metadata

Assignees

Labels

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions