Skip to content

Adding streamlit run by url#99

Merged
monchier merged 8 commits intostreamlit:developfrom
monchier:run-from-http
Sep 14, 2019
Merged

Adding streamlit run by url#99
monchier merged 8 commits intostreamlit:developfrom
monchier:run-from-http

Conversation

@monchier
Copy link
Copy Markdown
Contributor

We want to support streamlit run <url>

This PR adds support for this usage of the run command.

  • Added logic to recognize a url - we use validators.url for this. http://somethign is a url. something is not
  • Moved file validation from click to custom logic, since the first argument of run is now overloaded and can be file or url
  • Added cli unit tests

@monchier monchier requested review from kantuni and tvst September 12, 2019 20:58
@monchier monchier merged commit c746d46 into streamlit:develop Sep 14, 2019
@monchier monchier deleted the run-from-http branch September 16, 2019 17:06
tconkling added a commit to tconkling/streamlit that referenced this pull request Sep 17, 2019
# By Nahuel Emiliano Rosso Fandiño (3) and others
# Via GitHub
* develop:
  Fixing unbound local variable (streamlit#110)
  Support hashing dataframes with unhashable objects. Gracefully f… (streamlit#118)
  Fix hashing if the object has a name but the name is not a string. (streamlit#117)
  Fixed marshalling images with Alpha channel (streamlit#109)
  Adding `streamlit run` by url (streamlit#99)
  Fixed broken websocket when reconnect (streamlit#105)

# Conflicts:
#	lib/tests/streamlit/cli_test.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants