Skip to content

[Docs] Fix st.slider API in tutorial#98

Merged
tvst merged 2 commits intostreamlit:developfrom
erikhopf:sep12-patch
Sep 17, 2019
Merged

[Docs] Fix st.slider API in tutorial#98
tvst merged 2 commits intostreamlit:developfrom
erikhopf:sep12-patch

Conversation

@erikhopf
Copy link
Copy Markdown
Contributor

Quick update for the slider code i two places. Change from interactive report to interactive app.

Copy link
Copy Markdown
Contributor

@tvst tvst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after comments addressed

@tvst tvst changed the title [Docs] Patch for Sept 12 [Docs] Fix st.slider API in tutorial Sep 12, 2019
@erikhopf
Copy link
Copy Markdown
Contributor Author

@tvst - Once this passes the checks, I'l go ahead and merge.

@tvst
Copy link
Copy Markdown
Contributor

tvst commented Sep 16, 2019

Don't worry about the yellow check below. That requires you to click "accept" on a button, so our e2e tests can run. Not required for this.

Feel free to merge whenever.

@erikhopf
Copy link
Copy Markdown
Contributor Author

Hey @tvst, I'm not sure what's going on but the Merge pull request button is still greyed out for me.

@erikhopf
Copy link
Copy Markdown
Contributor Author

Screen Shot 2019-09-16 at 5 43 47 PM

@tvst tvst merged commit d855dfb into streamlit:develop Sep 17, 2019
tconkling added a commit to tconkling/streamlit that referenced this pull request Sep 23, 2019
* develop: (54 commits)
  Removing uber demo from streamlit repo (streamlit#159)
  Release 0.46.0 (streamlit#170)
  Magic fixes (streamlit#138)
  [docs] Add analytics; redirect /secret/docs; fix compilation problem (streamlit#149)
  Fix bug for startup under windows (streamlit#144)
  Responsive layout (streamlit#104)
  Add basic PR template
  Better method signatures (streamlit#88)
  Publish docs to both /docs and /secret/docs, until we deprecate /secret/docs in January. (streamlit#141)
  Rename/report2app (streamlit#126)
  Test running streamlit commands "bare" (streamlit#133)
  Updates to LP and sidebar. (streamlit#134)
  tests for z-index of date input popover in sidebar (streamlit#131)
  cypress test for escaping html in markdown (streamlit#125)
  On a Mac, check if xcode installed before requiring watchdog (streamlit#91)
  [Docs] Fix st.slider API in tutorial (streamlit#98)
  Sidebar exceptions (streamlit#107)
  Fixing unbound local variable (streamlit#110)
  Support hashing dataframes with unhashable objects. Gracefully f… (streamlit#118)
  Fix hashing if the object has a name but the name is not a string. (streamlit#117)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants