Clean up hello app #9760
Merged
Clean up hello app #9760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrieke
added
security-assessment-completed
lukasmasuch
approved these changes
Oct 31, 2024
Collaborator
lukasmasuch
left a comment
lukasmasuch
left a comment
There was a problem hiding this comment.
LGTM 👍 But some tests need to be updated
sfc-gh-bnisco
pushed a commit
that referenced
this pull request
Nov 6, 2024
## Describe your changes - Removes the deprecated `use_column_width` parameter from the hello app. - Cleans up a few smaller things in the hello app, such as lower-casing filenames, using sentence casing in the descriptions, moving the order of demos, and cleaning up the code. I want to do a bigger pass on the hello app in the future and add some new demos, but I thought I'd quickly fix the obvious things for now. ## GitHub Issue Link (if applicable) ## Testing Plan Hello app is already covered by e2e tests. --- **Contribution License Agreement** By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license. --------- Co-authored-by: Johannes Rieke <[email protected]> Co-authored-by: lukasmasuch <[email protected]>
edegp
pushed a commit
to edegp/streamlit
that referenced
this pull request
Jan 19, 2025
## Describe your changes - Removes the deprecated `use_column_width` parameter from the hello app. - Cleans up a few smaller things in the hello app, such as lower-casing filenames, using sentence casing in the descriptions, moving the order of demos, and cleaning up the code. I want to do a bigger pass on the hello app in the future and add some new demos, but I thought I'd quickly fix the obvious things for now. ## GitHub Issue Link (if applicable) ## Testing Plan Hello app is already covered by e2e tests. --- **Contribution License Agreement** By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license. --------- Co-authored-by: Johannes Rieke <[email protected]> Co-authored-by: lukasmasuch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
use_column_widthparameter from the hello app.GitHub Issue Link (if applicable)
Testing Plan
Hello app is already covered by e2e tests.
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.