Skip to content

Conversation

@lukasmasuch
Copy link
Collaborator

@lukasmasuch lukasmasuch commented Oct 31, 2024

Describe your changes

Applies two additional improvements to the update snapshot script:

  1. Asks for a personal access token if it cannot be auto-retrieved from the credential manager
  2. In case the latest workflow run is still in progress, the script waits and requests the latest state until the workflow is completed.

Contribution License Agreement

By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.

@lukasmasuch lukasmasuch added security-assessment-completed Security assessment has been completed for PR change:other PR contains other type of change impact:internal PR changes only affect internal code labels Oct 31, 2024
@lukasmasuch lukasmasuch marked this pull request as ready for review October 31, 2024 06:09
@lukasmasuch lukasmasuch merged commit 6a3b744 into develop Oct 31, 2024
@lukasmasuch lukasmasuch deleted the improve-update-snapshots-script branch October 31, 2024 22:57
edegp pushed a commit to edegp/streamlit that referenced this pull request Jan 19, 2025
## Describe your changes

Applies two additional improvements to the update snapshot script:

1. Asks for a personal access token if it cannot be auto-retrieved from
the credential manager
2. In case the latest workflow run is still in progress, the script
waits and requests the latest state until the workflow is completed.

---

**Contribution License Agreement**

By submitting this pull request you agree that all contributions to this
project are made under the Apache 2.0 license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

change:other PR contains other type of change impact:internal PR changes only affect internal code security-assessment-completed Security assessment has been completed for PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants