Disallow double slash paths to redirect #9754
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmcgrady
added
change:bugfix
kmcgrady
added
the
security-assessment-completed
kajarenc
approved these changes
Oct 30, 2024
mayagbarnes
approved these changes
Oct 30, 2024
lukasmasuch
approved these changes
Oct 30, 2024
Collaborator
lukasmasuch
left a comment
lukasmasuch
left a comment
There was a problem hiding this comment.
Another approval since PR requires server code owner
sfc-gh-mbarnes
approved these changes
Oct 30, 2024
edegp
pushed a commit
to edegp/streamlit
that referenced
this pull request
Jan 19, 2025
## Describe your changes We amend the call to remove the slash at the end if necessary. However, paths with double slashes `//my-path` create an invalid redirect that can cause security issues. This change prevents the double slash from matching with this route. ## GitHub Issue Link (if applicable) closes streamlit#9690 ## Testing Plan - Updated Unit Tests - Verified manually that redirect works as needed and fails with a double slash (and with a URL encoded double slash) --- **Contribution License Agreement** By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
We amend the call to remove the slash at the end if necessary. However, paths with double slashes
//my-pathcreate an invalid redirect that can cause security issues. This change prevents the double slash from matching with this route.GitHub Issue Link (if applicable)
closes #9690
Testing Plan
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.